Skip to content

fix: improve type safety for additional source builders (#2170)#5586

Open
mkcodes4 wants to merge 3 commits into
WordPress:mainfrom
mkcodes4:issue-2170
Open

fix: improve type safety for additional source builders (#2170)#5586
mkcodes4 wants to merge 3 commits into
WordPress:mainfrom
mkcodes4:issue-2170

Conversation

@mkcodes4

Copy link
Copy Markdown

Fixes

Fixes #2170

Description

This PR refactors get-additional-sources.ts to improve type safety and simplify runtime logic.

Key changes:

  • Introduced SelectiveRequired<T, K> utility type to enforce required properties after filtering.
  • Updated getAdditionalSourceBuilders to use a generic <T extends MediaType> for proper type narrowing.
  • Removed a redundant runtime check in getAdditionalSources since TypeScript now guarantees urlFunc is defined.

Testing Instructions

Run type-check on the frontend:

cd frontend
pnpm run types

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: MaryamKhan67 <khanworkmaryam@gmail.com>
@mkcodes4 mkcodes4 requested a review from a team as a code owner June 11, 2026 14:53
@mkcodes4 mkcodes4 requested review from krysal and obulat June 11, 2026 14:53
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 💻 aspect: code Concerns the software code in the repository labels Jun 11, 2026
@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs Jun 11, 2026
@mkcodes4 mkcodes4 requested a review from a team as a code owner June 12, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Projects

Status: 👀 Needs Review

Development

Successfully merging this pull request may close these issues.

Avoid type-guard in get-additional-sources

2 participants