fix: improve type safety for additional source builders (#2170)#5586
Open
mkcodes4 wants to merge 3 commits into
Open
fix: improve type safety for additional source builders (#2170)#5586mkcodes4 wants to merge 3 commits into
mkcodes4 wants to merge 3 commits into
Conversation
Signed-off-by: MaryamKhan67 <khanworkmaryam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2170
Description
This PR refactors
get-additional-sources.tsto improve type safety and simplify runtime logic.Key changes:
SelectiveRequired<T, K>utility type to enforce required properties after filtering.getAdditionalSourceBuildersto use a generic<T extends MediaType>for proper type narrowing.getAdditionalSourcessince TypeScript now guaranteesurlFuncis defined.Testing Instructions
Run type-check on the frontend:
cd frontend pnpm run typesChecklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin