-
Notifications
You must be signed in to change notification settings - Fork 0
Accept Realtime client + channelName in sessions #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * Wraps the two paths chat-js uses (see ChatClient._addAgent): the | ||
| * `options.agents` mutation (read by ably-js when opening the initial | ||
| * WebSocket) and the `params.agent` channel option (sent on ATTACH so | ||
| * an already-open connection still carries the identifier). | ||
| * | ||
| * `options.agents` is a private API on the Realtime client — no public | ||
| * typed accessor exists in the `ably` package — so this module casts to a | ||
| * `RealtimeWithOptions` shape to write it. | ||
| */ | ||
|
|
||
| import type * as Ably from 'ably'; | ||
|
|
||
| import { VERSION } from '../version.js'; | ||
|
|
||
| interface RealtimeWithOptions extends Ably.Realtime { | ||
| options: { agents?: Record<string, string | undefined> }; | ||
| } | ||
|
|
||
| const SDK_NAME = 'ai-transport-js'; | ||
|
|
||
| /** | ||
| * Register this SDK on the supplied Realtime client and return the channel | ||
| * options the caller should pass to `client.channels.get(...)` so the agent | ||
| * is also carried on channel ATTACH. Sets | ||
| * `options.agents['ai-transport-js'] = VERSION`. Idempotent — repeated | ||
| * calls with the same client produce the same key/value. | ||
| * @param client - The Ably Realtime client to register on. | ||
| * @returns Channel options containing `params.agent` for `channels.get`. | ||
| */ | ||
| export const registerAgent = (client: Ably.Realtime): { params: { agent: string } } => { | ||
| // CAST: Ably.Realtime's public type omits `options.agents`, but the SDK | ||
| // does carry it at runtime. ably-chat-js relies on the same shape — see | ||
| // ChatClient._addAgent in https://github.com/ably/ably-chat-js. | ||
| const realtime = client as RealtimeWithOptions; | ||
| realtime.options.agents = { | ||
| ...realtime.options.agents, | ||
| [SDK_NAME]: VERSION, | ||
| }; | ||
| return { params: { agent: `${SDK_NAME}/${VERSION}` } }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.