ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads by dstrong23 · Pull Request #750 · adobecom/unity

dstrong23 · 2026-04-22T17:50:52Z

Resolves: MWPW-190444

Test URLs:

Fixes MWPW-190444 — removes the 512×512 minimum image dimension restriction from Firefly upload flows.

The 512×512 minimum was a product-specified requirement that has since been lifted. The restriction was enforced on the primary upload path but was never applied to the Edit flow (reference image upload from device), causing an inconsistency. Removing the config entries resolves both issues simultaneously: the primary upload no longer blocks small images, and the Edit flow inconsistency is moot.

Root Cause
The 512×512 minimum dimension was hardcoded in target-config.json under limits-firefly as minHeight: 512 and minWidth: 512. This config is merged into this.limits in action-binder.js at construction time and evaluated in checkImageDimensions(). Because isMinLimits is only truthy when both minWidth and minHeight are present, removing these keys from the config causes the minimum-dimension check block to become a no-op with no JS changes required.

The Edit flow (reference image upload via the prompt-bar widget) bypassed uploadImage() entirely and therefore never called checkImageDimensions(), which is why the inconsistency existed. Both paths now behave identically: no minimum dimension is enforced.

Changes
File: unitylibs/core/workflow/workflow-upload/target-config.json

Removed minHeight: 512 from limits-firefly
Removed minWidth: 512 from limits-firefly
All other limits (maxFileSize, allowedFileTypes) are unchanged
Photoshop and Lightroom limits (limits-photoshop, limits-lightroom) are completely unaffected
No JavaScript changes are required.

Verification
Confirmed minHeight/minWidth only exist in target-config.json in this repo (no other JS files hardcode these values)
Confirmed fallback.js reference to minHeight is a CSS property on a browser-compatibility banner — unrelated
Confirmed no API endpoint dynamically supplies dimension limits — this config is the single source of truth
Testing
Verify images smaller than 512×512 can be uploaded via the main upload flow on Firefly/Doodlebug pages
Verify images smaller than 512×512 can be uploaded via the Edit flow (reference image from device)
Verify images above maxFileSize (100MB) are still correctly rejected on both paths
Verify allowed file types (JPEG, PNG, WEBP) validation is still enforced
Verify Photoshop and Lightroom upload validation is unaffected
Jira
MWPW-190444

…refly uploads

aem-code-sync · 2026-04-22T17:50:56Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

fc0847e ✅ (latest)
0f83536 ❌

…alytics dashboard. (#740) **Issue Fix Descriptions** : Explained in the comments **Testing Notes:** Refer to [wiki](https://wiki.corp.adobe.com/spaces/adobedotcom/pages/3835093951/PR+Testing+Notes+%E2%80%94+Analytics+Upload+Reliability+Fixes) Resolves: [MWPW-192702](https://jira.corp.adobe.com/browse/MWPW-192702) **Test URLs:** Before: https://main--cc--adobecom.aem.page/products/firefly/features/remove-object-from-photo?unitylibs=stage After: https://main--cc--adobecom.aem.page/products/firefly/features/remove-object-from-photo?unitylibs=analyticsIssues --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>

Resolves: [MWPW-189974](https://jira.corp.adobe.com/browse/MWPW-189974) [MWPW-189488](https://jira.corp.adobe.com/browse/MWPW-189488) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/products/firefly/features/remove-object-from-photo?unitylibs=stage - After: https://main--cc--adobecom.aem.page/products/firefly/features/remove-object-from-photo?unitylibs=bugfixesv2 --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>

* Implementing fetch request to page config API post-LCP * Scalable and backwards-compatible approach to fetch experiment data and leverage location header for successive API calls Resolves: [MWPW-191927](https://jira.corp.adobe.com/browse/MWPW-191927) **Test URLs:** - Before: https://main--dc--adobecom.aem.page/acrobat/online/compress-pdf?unitylibs=stage - After: https://main--dc--adobecom.aem.page/acrobat/online/compress-pdf?unitylibs=MWPW-191927

Reverts #747

Reverts #742

…rs in analytics dashboard. " (#757) Reverts #740

Testing Notes: 1. Regress all the upload workflow acros products 2. Test the limits for each product Resolves: [MWPW-193670](https://jira.corp.adobe.com/browse/MWPW-193670) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/drafts/arugupta/image-to-video/doodlebug/image-to-video?unitylibs=stage - After: https://main--da-cc--adobecom.aem.page/drafts/arugupta/image-to-video/doodlebug/image-to-video?unitylibs=wave2-video --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com>

dstrong23 · 2026-04-28T19:14:54Z

You can use https://main--da-cc--adobecom.aem.page/products/firefly/features/ai-cartoon-generator?unitylibs=ado-MWPW-190444-remove-512-dimension to test this PR.

…754) * Enable milolibs/unitylibs query params on stage URLs Resolves: [MWPW-191633](https://jira.corp.adobe.com/browse/MWPW-191633) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/?martech=off - After: https://MWPW-191633-support-milolibs-stage--cc--adobecom.aem.live/?martech=off > Note that this has a supporting PR in `adobecom/da-cc` as well at adobecom/da-cc#45 **Dev validation:** (using browser overrides) URL 1: https://www.stage.adobe.com/products/firefly/features/remove-person-from-photo.html?milolibs=ratko-test&unitylibs=doodlebug-v152-2 URLs by domain: [ff-doodlebug_milolibs_unitylibs_js_urls.md](https://github.com/user-attachments/files/27097349/ff-doodlebug_milolibs_unitylibs_js_urls.md) URL 2: https://www.stage.adobe.com/creativecloud/plans.html?milolibs=ratko-test&unitylibs=doodlebug-v152-2 URLs by domain: [plans_milolibs_js_urls.md](https://github.com/user-attachments/files/27097352/plans_milolibs_js_urls.md) URL 3: https://www.stage.adobe.com/products/firefly/features/remove-person-from-photo.html?milolibs=ratko-test URLs by domain: [doodlebug_milolibs_js_urls.md](https://github.com/user-attachments/files/27097356/doodlebug_milolibs_js_urls.md) URL 4: https://www.stage.adobe.com/products/firefly/features/remove-person-from-photo.html?unitylibs=doodlebug-v152-2 URLs by domain: [doodlebug_unitylibs_js_urls.md](https://github.com/user-attachments/files/27097358/doodlebug_unitylibs_js_urls.md)

asonnalagi · 2026-05-04T09:09:30Z

Verified main upload flow and Edit flow. All looks fine. All error toasts are working fine.
Able to upload images which are smaller than 512×512.
Device testing has stage dependency. Once this PR will merge to stage will verify in device.
Verified Photoshop and lightroom as well. These are unaffected.
Test results are in the subtask: MWPW-194282

Resolves: [MWPW-194052](https://jira.corp.adobe.com/browse/MWPW-194052) [MWPW-193773](https://jira.corp.adobe.com/browse/MWPW-193773) [MWPW-193716](https://jira.corp.adobe.com/browse/MWPW-193716) [MWPW-194279](https://jira.corp.adobe.com/browse/MWPW-194279) [MWPW-194149](https://jira.corp.adobe.com/browse/MWPW-194149) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/drafts/arugupta/image-to-video/doodlebug/image-to-video?unitylibs=stage - After: https://main--da-cc--adobecom.aem.page/drafts/arugupta/image-to-video/doodlebug/image-to-video?unitylibs=wave2vid-followup --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>

vipu0303 · 2026-05-19T12:09:08Z

    "limits-firefly": {
      "allowedFileTypes": ["image/jpeg", "image/png", "image/jpg", "image/webp"],
-      "maxFileSize": 100000000,
-      "minHeight": 512,


This alone will not help remove this file dimensions check completely.
As per the code, We still proceed for extracting the file dimensions first, and then if we don't find the minWidth/minHeight in target config, only then we skip and proceed further. Just in case we error out while finding the dimensions we fail even if no limits are mentioned in target config.
We should simply remove the check at the first place where we are calling this, cleanup the code, alongside removing the limits from the targetconfig.json.
@dstrong23 @sanjayms01

@vipu0303 That's a good point. I see you have another PR to take up that change. Is that correct?

fix(MWPW-190444): remove 512x512 minimum dimension restriction for Fi…

0f83536

…refly uploads

dstrong23 requested review from arugupta1992, sanjayms01 and vipu0303 April 22, 2026 17:50

dstrong23 mentioned this pull request Apr 22, 2026

fix(MWPW-190444): remove 512x512 minimum dimension restriction from Firefly upload config #749

Closed

5 tasks

arugupta1992 and others added 8 commits April 23, 2026 12:42

Revert "MWPW-191927 Implementing Config-Based A/B Testing" (#755)

6ce58c3

Reverts #747

MWPW-191927 Implementing Config-Based A/B Testing (#756)

dbb7a0a

Revert "[MWPW-189488, MWPW-189974] : Bug fixes " (#758)

7a06169

Reverts #742

Revert "[MWPW-192702] Fixing issues observed from evaluating the erro…

9e5f123

…rs in analytics dashboard. " (#757) Reverts #740

vipu0303 approved these changes Apr 30, 2026

View reviewed changes

sanjayms01 approved these changes May 1, 2026

View reviewed changes

sanjayms01 assigned asonnalagi May 1, 2026

sanjayms01 added firefly needs verification labels May 1, 2026

sanjayms01 changed the title ~~ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Fi…~~ ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads May 1, 2026

asonnalagi added verified and removed needs verification labels May 4, 2026

arugupta1992 and others added 2 commits May 5, 2026 11:42

Merge branch 'stage' into ado-MWPW-190444-remove-512-dimension

fc0847e

sanjayms01 force-pushed the stage branch from 0eddf8c to 0f4c8d8 Compare May 12, 2026 17:10

vipu0303 reviewed May 19, 2026

View reviewed changes

vipu0303 requested changes May 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads#750

ADO-fix (MWPW-190444): remove 512x512 minimum dimension restriction for Firefly uploads#750
dstrong23 wants to merge 12 commits into
stagefrom
ado-MWPW-190444-remove-512-dimension

dstrong23 commented Apr 22, 2026 •

edited by sanjayms01

Loading

Uh oh!

aem-code-sync Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

dstrong23 commented Apr 28, 2026

Uh oh!

asonnalagi commented May 4, 2026

Uh oh!

vipu0303 May 19, 2026

Uh oh!

sanjayms01 May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

dstrong23 commented Apr 22, 2026 • edited by sanjayms01 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aem-code-sync Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dstrong23 commented Apr 28, 2026

Uh oh!

asonnalagi commented May 4, 2026

Uh oh!

vipu0303 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

sanjayms01 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dstrong23 commented Apr 22, 2026 •

edited by sanjayms01

Loading

aem-code-sync Bot commented Apr 22, 2026 •

edited

Loading