Skip to content

feat: accept vkey from config#358

Open
hadjiszs wants to merge 4 commits into
mainfrom
feat/vkey-from-config
Open

feat: accept vkey from config#358
hadjiszs wants to merge 4 commits into
mainfrom
feat/vkey-from-config

Conversation

@hadjiszs

@hadjiszs hadjiszs commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Context

op-succinct upgrades need a new release of the aggkit prover for nothing more than updating the vkeys.

The suggestion is to take optionally those vkey from config so that no aggkit prover release / image is needed whenever we upgrade op-succinct.

Solution

Implement a small cli command to output the config values to use for the new upgrade op-succinct elfs:

cargo run -p aggkit-prover -- op-succinct-vkey --elf-dir /path/to/elf/directory/

It outputs:

[aggchain-proof-service.op-succinct]
aggregation-vkey = "0x..."
range-vkey-commitment = "0x..."
# aggregation on-chain vkey hash (bytes32): 0x...

Then, only config update is needed for aggkit-prover instead of new release

@hadjiszs hadjiszs requested a review from a team as a code owner June 9, 2026 11:43

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@hadjiszs hadjiszs marked this pull request as draft June 9, 2026 12:08
@hadjiszs hadjiszs marked this pull request as ready for review June 9, 2026 13:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cdb82895d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +79 to +82
let _ = aggregation::VKEY_OVERRIDE.set(decode_verifying_key(bytes)?);
}
if let Some(commitment) = range_vkey_commitment {
let _ = range::VKEY_COMMITMENT_OVERRIDE.set(commitment);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject conflicting vkey override installs

When the same process constructs more than one service with different op-succinct override config, OnceLock::set returns Err here but the error is discarded, so the second service keeps using the first service's vkey/commitment and can reject otherwise-valid proofs or fail against the second chain's on-chain config. This also violates /workspace/provers/AGENTS.md guidance to never silently discard errors with let _ = on fallible operations; please either error on conflicting repeats or verify the existing value matches the requested override.

Useful? React with 👍 / 👎.

@hadjiszs hadjiszs enabled auto-merge June 12, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant