Conversation
|
|
||
| let show_result ?(verbose=false) = function | ||
| | `Error code -> sprintf "(%d) %s" (Curl.errno code) (Curl.strerror code) | ||
| | `Ok (n, content) -> sprintf "http %d%s" n (if verbose then ": " ^ content else "") |
Contributor
There was a problem hiding this comment.
would be useful to have a show_simple_result counterpart
Contributor
Author
There was a problem hiding this comment.
now simple_result is just Ok string | Error string
would be nice to switch it to Result.t though
Contributor
There was a problem hiding this comment.
yes! result would be good
maybe too much backwards compat breaking? but OTOH it should be not too difficult to change on user-side
Contributor
Author
There was a problem hiding this comment.
compromise, changed "internal" response type to result but keeping existing functions unchanged
Comment on lines
144
to
147
| val http_request_ : result:(Curl.t * [ `Error of Curl.curlCode | `Ok of int * string ] -> 'r) -> 'r request | ||
| val http_request' : [ `Error of Curl.curlCode | `Ok of int * string ] request | ||
| val http_request : [ `Error of string | `Ok of string ] request | ||
| val http_request_exn : string request |
Contributor
There was a problem hiding this comment.
that's a large collection of names that are a bit arcane, the type is the only guiding element here
maybe http_request_ should be http_request_k (same k as ksprintf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no more breakage, just expose callback to get after-transfer info