Add API module to provide a simple interface to the Meshroom scene#3128
Add API module to provide a simple interface to the Meshroom scene#3128Alxiice wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new meshroom.api package to provide a simplified interface for interacting with Meshroom plugins and scenes, along with comprehensive unit tests. The review feedback highlights several key improvement opportunities and potential bugs: a type error in setLoglevel when handling invalid log levels, a type mismatch in getBackdropNodes that could cause incorrect node filtering, unnecessary access to private attributes (_name and _compatibilityNodes), an inefficient O(N) lookup in getNode that can be optimized to O(1), redundant list comprehensions in getNodeAttributes, and unused or duplicate imports in the test file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
cb2577c to
3e29525
Compare
0167033 to
94ac39a
Compare
1e060c4 to
ca58027
Compare
There was a problem hiding this comment.
Meshroom currently has no notion of public versus private APIs. Adding such a concept would require a larger architectural change and project-wide agreement, which is beyond the scope of this PR.
In its current state, the proposed changes introduce additional complexity and ambiguity without establishing the underlying framework needed to support them. Consequently, this PR will not be merged.
The new features to manipulate scenes should be moved in an existing module.
9650eaa to
ca5d99e
Compare
ca5d99e to
f31ec7e
Compare
Description
Add a new
apimodule to offer an easier interface to scene and nodes.Features