Skip to content

graphIO: serialize username that saved the file#3134

Open
Alxiice wants to merge 2 commits into
developfrom
feature/save_saving_username
Open

graphIO: serialize username that saved the file#3134
Alxiice wants to merge 2 commits into
developfrom
feature/save_saving_username

Conversation

@Alxiice

@Alxiice Alxiice commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

In the serialized file, save the username that last saved the file.
It could be interesting for stat purposes, we can get the modification date with statbut not the username easily.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the current username to the serialized file header using getpass.getuser(). Feedback suggests wrapping the getpass.getuser() call in a try-except block to prevent potential crashes in environments where user information is unavailable, such as containerized or headless systems.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread meshroom/core/graphIO.py Outdated
@Alxiice Alxiice added the feature new feature (proposed as PR or issue planned by dev) label Jun 11, 2026
@Alxiice Alxiice added this to the Meshroom 2026.1.0 milestone Jun 11, 2026
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (1d89d80) to head (6838825).
⚠️ Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
meshroom/core/graphIO.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3134      +/-   ##
===========================================
- Coverage    86.07%   86.06%   -0.01%     
===========================================
  Files           78       78              
  Lines        12111    12117       +6     
===========================================
+ Hits         10425    10429       +4     
- Misses        1686     1688       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice
Alxiice force-pushed the feature/save_saving_username branch 2 times, most recently from 634fce6 to 1ffe855 Compare June 22, 2026 07:30
@Alxiice
Alxiice force-pushed the feature/save_saving_username branch 4 times, most recently from fb48e34 to 7492027 Compare July 1, 2026 08:16
@Alxiice
Alxiice force-pushed the feature/save_saving_username branch 2 times, most recently from a46b19c to 2cf5795 Compare July 7, 2026 10:27
@Alxiice
Alxiice force-pushed the feature/save_saving_username branch from 2cf5795 to 6838825 Compare July 15, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant