Advanced submitter settings#3141
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces submission and stage settings classes (MeshroomCommandWrapper, StageSettings, and SubmitionSettings) to manage remote computing configurations for nodes, alongside type annotation and naming refactors in OrderedTask. Feedback focuses on correcting spelling typos (e.g., renaming SubmitionSettings to SubmissionSettings), fixing potential AttributeErrors when accessing .value on level parameters, correcting typos in deprecation warnings, and removing redundant attribute assignments in StageSettings due to its inheritance from SimpleNamespace.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (56.52%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
- Coverage 86.09% 85.96% -0.14%
===========================================
Files 80 80
Lines 12127 12154 +27
===========================================
+ Hits 10441 10448 +7
- Misses 1686 1706 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aff904a to
4b56ddb
Compare
a170be1 to
f563ef2
Compare
2b94bcc to
7264272
Compare
7264272 to
63fce55
Compare
…on the node to override submition settings
…er use what it needs and the nodes declare a wrapper if needed
63fce55 to
ae77fb7
Compare
Description
Add a system to setup advanced settings on submitter
Before this PR there was 2 issues :
Also for the mrSubmitters submitter it was really challenging to setup a proper job for Windows.
Details
In this PR we are adding 2 key elements :
SubmitionSettings&StageSettingsclasses to describe settings for a specific processing stage (preprocess,process/processChunkandpostprocess)desc.BaseNode:getSubmitionSettings. By default it is built using the nodeDesc :cpu/ram/gpuare settings used for theprocessstage only,pre/post processare using default settings.Features
StageSettingsis built usingSimpleNamespaceso we can technically set anything on a stage settings and use it later on the submitter.Example