UI: Add buttons to unlock the node#3158
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds 'Unlock Node' and 'Unlock Selected Nodes' menu items to the GraphEditor context menu. The review feedback suggests avoiding the use of _currentScene to maintain component encapsulation and recommends enabling the 'Unlock Selected Nodes' item only when there is an active selection to prevent accidentally unlocking all nodes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3158 +/- ##
========================================
Coverage 86.09% 86.09%
========================================
Files 80 80
Lines 12127 12127
========================================
Hits 10441 10441
Misses 1686 1686 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1f702bd to
b4918c5
Compare
b4918c5 to
b483828
Compare
cbentejac
left a comment
cbentejac
left a comment
There was a problem hiding this comment.
Minor changes requested regarding the two new options in the Graph Editor. Otherwise, looks good to me.
| MenuItem { | ||
| text: "Unlock Node" | ||
| enabled: nodeMenu.currentNode.locked | ||
| height: visible ? implicitHeight : 0 | ||
| onTriggered: uigraph.graph.forceUnlockNodes([nodeMenu.currentNode]) | ||
| } | ||
| MenuItem { | ||
| text: "Unlock Selected Nodes" | ||
| height: visible ? implicitHeight : 0 | ||
| onTriggered: uigraph.graph.forceUnlockNodes(_currentScene.getSelectedNodes()) | ||
| } |
There was a problem hiding this comment.
This is a bit counter-intuitive: to enable the "Unlock Node", the selected node NEEDS to be locked (which makes sense). However, even if a single node is selected, the "Unlock Selected Nodes" option will always be enabled because there is no check on whether the selection contains more than one node and whether it contains at least a locked one.
| MenuItem { | ||
| text: "Unlock Selected Nodes" | ||
| height: visible ? implicitHeight : 0 | ||
| onTriggered: uigraph.graph.forceUnlockNodes(_currentScene.getSelectedNodes()) | ||
| } |
There was a problem hiding this comment.
I would probably also hide (and not just disable) the "Unlock Selected Nodes" option if there's only one selected node.
b483828 to
fd48ae7
Compare
2 participants
Description
Add 2 buttons on the Graph Editor node context menu:
When the node is locked you can simply unlock this node:
Also you can unlock selected nodes:
