[UI] Add an auto-scroll feature to connect edges on huge scenes#3159
[UI] Add an auto-scroll feature to connect edges on huge scenes#3159Alxiice wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3159 +/- ##
========================================
Coverage 85.75% 85.75%
========================================
Files 78 78
Lines 12087 12087
========================================
Hits 10365 10365
Misses 1722 1722 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces an autoscroll feature to the Graph Editor when dragging attribute pin edges near the workspace boundaries. It also refactors the QmlInstantEngine to inherit from QObject instead of QQmlApplicationEngine to facilitate cleaner hot-reloads. The review feedback identifies several key issues: inefficient signal emission and a correctness bug in the edge dragging logic of AttributePin.qml, potential runaway scrolling speeds when dragging far outside the Graph Editor boundaries, and a missing parent reference for a QTimer in utils.py that could lead to memory leaks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
8d2fe99 to
030c50a
Compare
2997ee4 to
567d3d9
Compare
… send edge dragging info
…pproach the GraphEditor borders
…t previously triggered
567d3d9 to
96fc92e
Compare
Description
When scenes are too big and we want to connect nodes that cannot be seen at the same time, it's not convenient to create edges.
This PR aims to add an "auto-scroll" feature that will move the graph when we approach the edges of the graph editor. This way users can easily drag edges, move in the graph and connect the edges.
Notes for the review
Aside from the code review I would like to know what would be the best settings for
Demo