Skip to content

[UI] Add an auto-scroll feature to connect edges on huge scenes#3159

Open
Alxiice wants to merge 6 commits into
developfrom
fix/move_in_graph_while_connecting_nodes
Open

[UI] Add an auto-scroll feature to connect edges on huge scenes#3159
Alxiice wants to merge 6 commits into
developfrom
fix/move_in_graph_while_connecting_nodes

Conversation

@Alxiice

@Alxiice Alxiice commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

When scenes are too big and we want to connect nodes that cannot be seen at the same time, it's not convenient to create edges.

This PR aims to add an "auto-scroll" feature that will move the graph when we approach the edges of the graph editor. This way users can easily drag edges, move in the graph and connect the edges.

Notes for the review

Aside from the code review I would like to know what would be the best settings for

  • the border margins (threshold where the scroll is enabled)
  • the scroll speed

Demo

auto scroll

@Alxiice Alxiice self-assigned this Jul 3, 2026
@Alxiice Alxiice added the feature new feature (proposed as PR or issue planned by dev) label Jul 3, 2026
Comment thread meshroom/ui/utils.py Fixed
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.75%. Comparing base (507e2dc) to head (567d3d9).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3159   +/-   ##
========================================
  Coverage    85.75%   85.75%           
========================================
  Files           78       78           
  Lines        12087    12087           
========================================
  Hits         10365    10365           
  Misses        1722     1722           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an autoscroll feature to the Graph Editor when dragging attribute pin edges near the workspace boundaries. It also refactors the QmlInstantEngine to inherit from QObject instead of QQmlApplicationEngine to facilitate cleaner hot-reloads. The review feedback identifies several key issues: inefficient signal emission and a correctness bug in the edge dragging logic of AttributePin.qml, potential runaway scrolling speeds when dragging far outside the Graph Editor boundaries, and a missing parent reference for a QTimer in utils.py that could lead to memory leaks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread meshroom/ui/qml/GraphEditor/AttributePin.qml Outdated
Comment thread meshroom/ui/qml/GraphEditor/AttributePin.qml
Comment thread meshroom/ui/qml/GraphEditor/GraphEditor.qml
Comment thread meshroom/ui/utils.py Outdated
@Alxiice
Alxiice changed the base branch from develop to fix/qml_instant_coding July 4, 2026 18:13
@Alxiice
Alxiice requested a review from yann-lty July 5, 2026 06:54
@Alxiice
Alxiice force-pushed the fix/move_in_graph_while_connecting_nodes branch 2 times, most recently from 8d2fe99 to 030c50a Compare July 6, 2026 10:59
@Alxiice
Alxiice changed the base branch from fix/qml_instant_coding to develop July 6, 2026 14:30
@Alxiice
Alxiice force-pushed the fix/move_in_graph_while_connecting_nodes branch from 2997ee4 to 567d3d9 Compare July 7, 2026 10:21
@Alxiice
Alxiice force-pushed the fix/move_in_graph_while_connecting_nodes branch from 567d3d9 to 96fc92e Compare July 15, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant