Graph Input/Output nodes and API#3164
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/outputNode #3164 +/- ##
======================================================
- Coverage 85.93% 85.81% -0.13%
======================================================
Files 79 79
Lines 12289 12313 +24
======================================================
+ Hits 10561 10566 +5
- Misses 1728 1747 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request generalizes input and output node handling in Meshroom by introducing IONode, InputNode, and OutputNode base classes, replacing hardcoded CopyFiles logic, and adding new GraphInput and GraphOutput nodes. Key feedback includes fixing Python syntax errors in type annotations (using colons instead of commas in dictionary types), correcting a serialization logic bug where a break statement prematurely exits a loop, adding defensive checks for empty paths and null values in both Python and QML to prevent runtime errors, and correcting a minor typo in the documentation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1ee5a73 to
419c909
Compare
Add node to fetch parameter values from another Meshroom scene
3aca07b to
504e11b
Compare
Description
Add
GraphInputandGraphOutputnodes.The meshroom_batch API has been modified:
Fetch the graph input attributes
Set the graph input parameters
A new attribute
-gi/--graphInputcan be used to set a parameter in the inputs.If multiple
GraphInputnodes have the parameter they will all be set to the given value.This is similar to using
--paramOverrides GraphInput:ATTRNAME=VAL.Set the graph output parameters
A new attribute
-go/--graphOutputcan be used to set a parameter in the outputs.Note
This is a simple redirection to
output, this argument is just a way to avoid fetching the GraphOutput nodes names