Improve performance on path manipulation nodes#3167
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors several utility nodes (FlattenFiles, GetParentFolder, and PathJoin) to inherit from desc.CommandLineNode instead of desc.Node, transitioning their execution logic from process to processChunk. It also introduces a new GetFileExtension node. The feedback suggests adding a defensive check in the new GetFileExtension node to prevent a potential TypeError if the input path is empty or None.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3167 +/- ##
===========================================
- Coverage 86.07% 86.07% -0.01%
===========================================
Files 78 78
Lines 12111 12115 +4
===========================================
+ Hits 10425 10428 +3
- Misses 1686 1687 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fabiencastan
left a comment
There was a problem hiding this comment.
Do not use commandlinenode for that. This is hack. Add a way to disable subprocess in Node.
|
@fabiencastan I added a |
Description
GetFileExtensiondesc.Nodebydesc.CommandLineNodeonGetParentFolderFlattenFilesPathJoinUsing CommandLineNode bypass the
_processInIsolatedEnvironmentcall (see #3166) that launches a subprocess.Bypassing it saves several seconds: the node compute takes almost 0 sec.