Skip to content

Fix case where HDF5 comes from the system #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 2 commits into from
Jul 24, 2025
Merged

Fix case where HDF5 comes from the system #5953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6817bd
Fix case where HDF5 comes from the system
singiamtel Jul 14, 2025
1d4cead
Pickup HDF5 from system in macos too
singiamtel Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion yoda.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,15 @@

export PYTHON=$(type -p python3)

./configure --disable-silent-rules --enable-root --prefix="$INSTALLROOT" --with-hdf5="$HDF5_ROOT"
case $ARCHITECTURE in
osx*)
# If we preferred system tools, we need to make sure we can pick them up.
[[ ! $HDF5_ROOT ]] && HDF5_ROOT="$(brew --prefix hdf5)"

Check notice on line 27 in yoda.sh

View workflow job for this annotation

GitHub Actions / alidistlint 

Prefer explicit -n to check non-empty string (or use =/-ne to check boolean/integer). [SC2244]
;;
*) ;;
esac

./configure --disable-silent-rules --enable-root --prefix="$INSTALLROOT" ${HDF5_ROOT:+--with-hdf5=$HDF5_ROOT}
Comment thread
singiamtel marked this conversation as resolved.
make ${JOBS+-j $JOBS}
make install

Expand Down