Skip to content

Bump CMake to 4.2.3 and boost to 1.90#6135

Merged
ktf merged 31 commits into
alisw:masterfrom
davidrohr:master_pull_request
Mar 31, 2026
Merged

Bump CMake to 4.2.3 and boost to 1.90#6135
ktf merged 31 commits into
alisw:masterfrom
davidrohr:master_pull_request

Conversation

@davidrohr
Copy link
Copy Markdown
Contributor

No description provided.

@davidrohr davidrohr requested a review from a team as a code owner February 17, 2026 12:58
@davidrohr davidrohr force-pushed the master_pull_request branch 5 times, most recently from 116206b to 187fd8a Compare February 17, 2026 21:40
@davidrohr davidrohr requested a review from a team as a code owner February 17, 2026 21:40
@davidrohr davidrohr force-pushed the master_pull_request branch 5 times, most recently from 09b091f to 3bb76fa Compare February 18, 2026 15:09
@davidrohr davidrohr mentioned this pull request Feb 19, 2026
@davidrohr davidrohr force-pushed the master_pull_request branch 2 times, most recently from dca7dff to 1691e86 Compare February 21, 2026 18:05
@davidrohr davidrohr force-pushed the master_pull_request branch from 1691e86 to 93067b3 Compare March 2, 2026 19:44
@davidrohr davidrohr requested a review from a team as a code owner March 2, 2026 19:44
@davidrohr davidrohr force-pushed the master_pull_request branch from 93067b3 to b8fc349 Compare March 3, 2026 10:14
@davidrohr davidrohr requested a review from a team as a code owner March 3, 2026 10:14
@davidrohr davidrohr force-pushed the master_pull_request branch 2 times, most recently from 8f35c4a to 0ffd12f Compare March 4, 2026 12:04
@davidrohr davidrohr requested a review from a team as a code owner March 4, 2026 12:04
@davidrohr davidrohr force-pushed the master_pull_request branch 2 times, most recently from b265d10 to f6b3702 Compare March 11, 2026 12:15
@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 16, 2026

@davidrohr actually it seems to fail also on linux. I suspect this is the old issue which we patched on our side. Do you see it when running locally?

@davidrohr
Copy link
Copy Markdown
Contributor Author

@davidrohr actually it seems to fail also on linux. I suspect this is the old issue which we patched on our side. Do you see it when running locally?

@ktf : You refer to

In file included from /Volumes/build/alice-ci-workdir/alidist-o2/sw/osx_arm64/boost/v1.90.0-local3/include/boost/histogram/indexed.hpp:16:
/Volumes/build/alice-ci-workdir/alidist-o2/sw/osx_arm64/boost/v1.90.0-local3/include/boost/histogram/detail/operators.hpp:48:14: error: use of overloaded operator '>' is ambiguous (with operand types 'const boost::histogram::indexed_range<boost::histogram::histogram<std::vector<boost::histogram::axis::variant<boost::histogram::axis::regular<float, boost::use_default, boost::use_default, boost::histogram::axis::option::bitset<0>>, boost::histogram::axis::integer<int, boost::use_default, boost::histogram::axis::option::bitset<0>>>>>>::accessor' and 'const boost::histogram::unlimited_storage<>::reference')
   48 |     return b > a;
      |            ~ ^ ~
/Volumes/build/alice-ci-workdir/alidist-o2/sw/osx_arm64/boost/v1.90.0-local3/include/boost/histogram/indexed.hpp:191:20: note: in instantiation of function template specialization 'boost::histogram::detail::operator<<boost::histogram::unlimited_storage<>::reference>' requested here

No, I do not see it on Linux locally on my laptop, and also the Linux CI here seems ok. They are randomly failing when rerunning, but all the Linux CIs have already been green in this PR.

@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 16, 2026

@davidrohr , no I meant the one about boost::interprocess:

[17996:B]: [03:54:34][STATE] Exiting FairMQ state machine
[17996:B]: [03:54:34][FATAL] error while setting up workflow in o2-framework-crashing-workflow: Could not initialize shared memory transport: Failed to create/open shared memory segment 'fmq_2251b784_m_0': boost::interprocess_exception::library_error
[17996:B]: terminate called after throwing an instance of 'o2::framework::RuntimeErrorRef'

I suspect this is the container enforces limits correctly issue we patched around in the previous version of boost.

@davidrohr
Copy link
Copy Markdown
Contributor Author

I suspect this is the container enforces limits correctly issue we patched around in the previous version of boost.

Ah, that could be. But then it happens randomly, since this has been green before. Only the MacOS CI was red few days ago.
I will check what that patch did exactly and if we can still apply it.

@davidrohr davidrohr force-pushed the master_pull_request branch from f6b3702 to e2b9f7a Compare March 16, 2026 18:12
@davidrohr davidrohr force-pushed the master_pull_request branch from 9095cdc to 44d2a70 Compare March 25, 2026 09:54
@ehellbar
Copy link
Copy Markdown
Contributor

@davidrohr the issue on the EPN was indeed related to the shm manager. Using the same O2PDPSuite for the shm-manager locally or for the service on staging, everything works fine.

@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 27, 2026

@nzardosh just confirmed for jet everything seems fine as well. Once the current issues with jenkins are fixed, I would go ahead and merge this.

@pzhristov
Copy link
Copy Markdown
Contributor

@alisw/dataflow-experts Do you have any news?

@davidrohr
Copy link
Copy Markdown
Contributor Author

@ktf : validation by FLPs are done: https://its.cern.ch/jira/browse/OCONF-907
I think we can merge it. Do you want to synchronize with the new boost, or we just go ahead with this?

@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 31, 2026

Let's merge this and then we think about it.

@ktf ktf merged commit 7a26c16 into alisw:master Mar 31, 2026
12 of 14 checks passed
@ehellbar ehellbar mentioned this pull request Apr 7, 2026
Comment thread treelite.sh

cmake --build . -- ${JOBS:+-j$JOBS} install

[[ -d $INSTALLROOT/lib64 ]] && [[ ! -d $INSTALLROOT/lib ]] && ln -sf ${INSTALLROOT}/lib64 $INSTALLROOT/lib
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symlink lib -> lib64 is not relocated which is currently breaking the AliPhysics CI builds:

lib -> /sw/INSTALLROOT/6f8bcece55616f5b23671770a825fc8e1249b05f/slc7_x86-64/treelite/df6a892b7faf532aea13bacc0f30b8a4743f82cf-local1/lib64

Comment thread treelite.sh

cmake --build . -- ${JOBS:+-j$JOBS} install

[[ -d $INSTALLROOT/lib64 ]] && [[ ! -d $INSTALLROOT/lib ]] && ln -sf ${INSTALLROOT}/lib64 $INSTALLROOT/lib
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[ -d $INSTALLROOT/lib64 ]] && [[ ! -d $INSTALLROOT/lib ]] && ln -sf ${INSTALLROOT}/lib64 $INSTALLROOT/lib
[[ -d $INSTALLROOT/lib64 ]] && [[ ! -d $INSTALLROOT/lib ]] && ln -sf lib64 $INSTALLROOT/lib

I guess a relative link should fix it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually a way to tell CMake to use lib rather than lib64. I would use that. @singiamtel can you have a look?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only vaguely remember, but I think I tried the CMake libdir setting, and it failed for some reason, that is why I put the symlink. We can of course try to fix it the "correct" way, but if that causes issues, I would just create a relative symlink.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if #6213 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants