Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Require
bitreq0.3.4 and add a regression test covering the issue #101 scenario where a pooled keep-alive socket is later closed by the server.The intent here is to avoid carrying a local
BitreqClientreset workaround in this crate and instead:bitreq0.3.4Cargo.tomlrpcservertimeout-style idle socket close caseType of Change
Notes to Reviewers
This PR intentionally does not add a local pool-reset workaround.
I checked the reported issue scenario against
bitreq0.3.4 and could not reproduce the permanent poisoned-pool behavior described in #101. The new test keeps a connection alive long enough to be pooled, then closes it server-side and verifies the next RPC still succeeds.This also keeps us aligned with the upstream direction in rust-bitcoin/corepc#564 rather than adding extra client-side complexity here.
Checklist
Related Issues
Related to #101. rust-bitcoin/corepc#564 with a
bitreqpublished version bump here would be the one to fix #101.