Skip to content

Update wavefront_obj dependency#314

Open
AnneKitsune wants to merge 4 commits intoamethyst:masterfrom
AnneKitsune:master
Open

Update wavefront_obj dependency#314
AnneKitsune wants to merge 4 commits intoamethyst:masterfrom
AnneKitsune:master

Conversation

@AnneKitsune
Copy link
Copy Markdown

@AnneKitsune AnneKitsune commented Jun 19, 2021

Needed as one of the dependency of the old wavefront_obj version cannot be built on the newest rust versions.
We also need someone to publish the update. Thanks!

@zakarumych
Copy link
Copy Markdown
Member

zakarumych commented Jun 20, 2021

This looks like breaking change, so minor version update of this and dependent crates should be made as well.

@zakarumych
Copy link
Copy Markdown
Member

I guess I still got rights for publishing on crates.io

@AnneKitsune
Copy link
Copy Markdown
Author

Gotcha

@AnneKitsune
Copy link
Copy Markdown
Author

Fixed! Also, do you think it would be possible to add the amethyst org/group as a crate owner, so that we can push small updates like this one if you are not available?

@zakarumych
Copy link
Copy Markdown
Member

Amethyst group is owner already.

@AnneKitsune
Copy link
Copy Markdown
Author

It gave access to the amethyst:rendy team, which has sadly been deleted during a cleanup. Recreating the team doesn't give access back to the crate 😂

@zakarumych
Copy link
Copy Markdown
Member

To which team should I transfer access rights?

@AnneKitsune
Copy link
Copy Markdown
Author

@amethyst/crate_access
https://github.com/orgs/amethyst/teams/crate_access

@zakarumych
Copy link
Copy Markdown
Member

I've added that team to owners list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants