Added monitor activity page for Fate transaction details#6371
Conversation
|
I was looking at the Bulk Import page on the monitor, and I'm not sure that we will be able to show that level of detail going forward. That information is serialized in an object in the Fate transaction for the Bulk Import. Getting access to the serialized object requires that we reserve the Fate transaction, which we can't do if it's currently executing. As a possible replacement for the Bulk Import page, this page shows the status of All Fate transactions (not just Bulk Import). It displays a lot of the same information as the command |
|
Screen shot of fate tx details page (under the activity menu) 
IIRC the held and waiting locks are the namespace id or table id. The lock range is the prevEndRow and endRow, so they might need to be obfuscated. |
| FateStatus status = AdminUtil.getTransactionStatus(stores, null, null, null, emptyLocks, | ||
| emptyLocks, emptyRanges); | ||
| summary.processFateTransactions(status.getTransactions()); |
There was a problem hiding this comment.
I might be missing something but do we ever populate emptyLocks, emptyLocks, emptyRanges? Given the names it seems like its intentional that they are empty but why render them in the UI at all in that case? Or are these placeholders for later?
There was a problem hiding this comment.
I passed empty collections here because passing null would have caused a NPE. Looking at the code again, I think I need to make another change.
There was a problem hiding this comment.
In 45917b2 I used a different method on AdminUtil to get the lock information.
|
Latest screenshot showing lock information and updated lock range type column. 
|
2 participants
No description provided.