feat: add recovery middleware to handle panic gracefully#1537
Open
hhc7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1536
Proposed Changes
middleware.Recovery()that catches panics from any subsequent middleware or handler, logs the panic message with full stack trace vialog.Errorf+debug.Stack(), and returns a unified 500 JSON response (reason: base.unknown) viahandler.NewRespBody+TrMsg— consistent with how other errors are handled ininternal/base/handler/handler.go.Recovery()as the first middleware ininternal/base/server/http.goso it covers all subsequent middleware (brotli, accept-language, short-id, auth, etc.) and handlers.recovery_test.gocovering both the panic path (verifies 500 +base.unknownreason) and the no-panic path (verifies normal requests pass through unaffected).