fix(ingress-controller): use webhook secret name from values when provided#955
Open
nikaro wants to merge 1 commit intoapache:masterfrom
Open
fix(ingress-controller): use webhook secret name from values when provided#955nikaro wants to merge 1 commit intoapache:masterfrom
nikaro wants to merge 1 commit intoapache:masterfrom
Conversation
…vided The webhook.certificate.secretName value in values.yaml was being ignored. The deployment always used the helper-generated name regardless of user input. This fix modifies the webhook.secretName helper to: - Check if webhook.certificate.provided is true AND secretName is set - Use the user-provided secret name when both conditions are met - Fall back to the generated default otherwise Fixes apache#954
Author
|
Can this be reviewed/merged/released? 🥺 |
Baoyuantop
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #954 by modifying the webhook.secretName helper to use the user-provided secret name from values.yaml when webhook.certificate.provided is true and webhook.certificate.secretName is set.