feat(ai-proxy*): support resolving secrets from environment variables and secret vaults#13143
feat(ai-proxy*): support resolving secrets from environment variables and secret vaults#13143mikyll wants to merge 20 commits intoapache:masterfrom
Conversation
Baoyuantop
left a comment
There was a problem hiding this comment.
I suggest adding a test case for auth.header + $ENV://.
Co-authored-by: Baoyuan <baoyuan.top@gmail.com>
|
Hi @mikyll, we've just fixed some CI issues. You can merge the main branch and then run CI again. |
Merge master to issue_13132
…y, since Nginx env var directive doesn't support spaces
|
@Baoyuantop I updated the I also tested it with a minimal Nginx setup and yes, spaces in env directive throw an error: Can you review again the PR? 🙂 |
|
@Baoyuantop I made a small change in documentation in 70f533f, other commits are just to merge from main The last time the CI passed, but it was missing 2 other approvals, any news? |
Baoyuantop
left a comment
There was a problem hiding this comment.
Sorry, I accidentally clicked "approve". We need to confirm the issue in the previous comment first.
|
Hi @mikyll, there are some code conflicts that need to be handled. |
|
@Baoyuantop conflicts solved 🙂 |
Description
This PR introduces the possibility to reference a secret in
ai-proxyandai-proxy-multiplugins, from a ENV variable or a Secret Manager service, as documented in APISIX Docs | Terminology | Secret.This change makes it possible to avoid hard-coding the API keys in
ai-proxy*plugin configuration 🙂The changes include:
fetch_secret()inai-proxy/base.luato resolve secrets.Which issue(s) this PR fixes:
Fixes #13132
Checklist