Fix PreCommit Java PVR Prism Loopback workflow#38431
Fix PreCommit Java PVR Prism Loopback workflow#38431stankiewicz merged 3 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a compatibility issue in the MetadataPropagationTest suite. Because PAssert internally triggers a GroupByKey operation, it causes coder mismatch errors on portable runners that do not yet support metadata propagation across such operations. Removing the ValidatesRunner category ensures that the test suite remains stable during PreCommit workflows. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates MetadataPropagationTest.java by adding descriptive Javadoc to the testMetadataPropagationParameter method and narrowing its test category from ValidatesRunner to NeedsRunner. The review feedback suggests refining the documentation to specify that the test requires metadata propagation support across GroupByKey operations due to the internal behavior of PAssert, and recommends adding a tracking issue for future runner support.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
The PreCommit Java PVR Prism Loopback workflow failed recently due to the following error in test
testMetadataPropagationParameter.According to the comment for
testMetadataPropagationAcrossGBK, portable runners like Prism do not yet support metadata propagation acrossGroupByKey, enabling metadata encoding causes an EOFException coder mismatch:beam/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java
Lines 107 to 110 in a8e7ffa
In
testMetadataPropagationParameter, even though there is no explicitGroupByKeystep,PAssert.that().containsInAnyOrder()internally introduces aGroupByKey. Therefore, we see the said error in this test as well.Removing
ValidatesRunneraligns this test with the other GBK-dependent tests in MetadataPropagationTest.fixes #36686