Skip to content

Fix ULR metadata propagation test flake #38437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aIbrahiim wants to merge 5 commits into from
+4 −2
Closed

Fix ULR metadata propagation test flake #38437

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
672a65d
Fix ULR metadata propagation test flake
aIbrahiim May 11, 2026
5473ebd
trigger the workflow
aIbrahiim May 11, 2026
54bb04f
Remove ValidatesRunner from metadata propagation test
aIbrahiim May 11, 2026
1d55437
trigger the workflow
aIbrahiim May 11, 2026
36da202
trigger workflow
aIbrahiim May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_ULR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"comment": "Modify this file in a trivial way to cause this test suite to run",
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
"https://github.com/apache/beam/pull/38437" : "Fix ULR metadata propagation test flake"
}
1 change: 1 addition & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public void testMetadataPropagationAcrossShuffleParameter() {
@Test
@Category({ValidatesRunner.class, NeedsRunner.class})
Comment thread
aIbrahiim marked this conversation as resolved.
Outdated
public void testMetadataPropagationParameter() {
WindowedValues.WindowedValueCoder.setMetadataSupported();
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The class name WindowedValues appears to be a typo for WindowedValue. This will likely cause a compilation error as the standard Beam class is WindowedValue.

Suggested change
WindowedValues.WindowedValueCoder.setMetadataSupported();
WindowedValue.WindowedValueCoder.setMetadataSupported();

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting global static state within a ValidatesRunner test can lead to test interference and flakes in other tests. Since this test is part of a suite that may run in parallel or in a shared JVM, consider using a setup/teardown mechanism (like @Before and @After) to ensure the state is properly initialized and reset, maintaining test isolation.

PCollection<String> results =
pipeline
.apply(Create.of(true))
Expand Down
Loading