Skip to content

upgrade test containers and fix issues#38438

Merged
derrickaw merged 1 commit into
apache:masterfrom
derrickaw:20260510_fixTestContainersVersion
May 11, 2026
Merged

upgrade test containers and fix issues#38438
derrickaw merged 1 commit into
apache:masterfrom
derrickaw:20260510_fixTestContainersVersion

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

@derrickaw derrickaw commented May 11, 2026

  1. Issues seen in Bump github.com/testcontainers/testcontainers-go from 0.40.0 to 0.42.0 in /sdks #38433
  2. nat is not a dependency anymore so removed

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the go label May 11, 2026
@derrickaw derrickaw marked this pull request as ready for review May 11, 2026 13:11
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the testcontainers-go dependency to version v0.42.0 to improve build stability and address issues identified in recent test runs. The transition necessitated the removal of the deprecated nat package from the Go SDK integration tests, requiring minor refactoring of helper functions to handle port definitions as strings. These changes ensure the test suite remains compatible with the latest container testing infrastructure.

Highlights

  • Dependency Upgrade: Upgraded the testcontainers-go library to version v0.42.0 to resolve compatibility issues.
  • Removal of Deprecated Package: Removed the github.com/docker/go-connections/nat dependency, which is no longer supported in the updated version.
  • Code Refactoring: Updated integration test helper functions to use string-based port representations instead of the removed nat.Port type.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Go dependencies, including testcontainers-go to v0.42.0, and refactors integration tests to use string-based port definitions, removing the dependency on nat.Port. Feedback suggests using net.JoinHostPort in jdbc_test.go to properly handle IPv6 addresses when constructing database URLs.

Comment thread sdks/go/test/integration/io/xlang/jdbc/jdbc_test.go
@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @lostluck for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw derrickaw merged commit a86f2ec into apache:master May 11, 2026
6 checks passed
aIbrahiim pushed a commit to aIbrahiim/beam that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants