CAMEL-23576: camel-jira - align Exchange header constant names with Camel naming convention#23472
Merged
oscerd merged 1 commit intoMay 22, 2026
Conversation
…amel naming convention Backport of apache#23417 onto camel-4.14.x. Renames the Exchange header string values in JiraConstants from non-Camel prefixed values (IssueKey, ProjectKey, IssueTransitionId, linkType, minutesSpent, ...) to CamelJira<Name>. The Java field names are unchanged so routes referencing the constants symbolically continue to work; routes using the literal string values must be updated (documented in the 4.14 upgrade guide as a potential breaking change). The generated Endpoint DSL header accessors on JiraHeaderNameBuilder are renamed accordingly. Producer error messages and the component docs are updated for consistency. Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
gnodet
approved these changes
May 22, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
Clean backport of #23417. Verified:
- Original PR is merged on
main(3240a17). - All 20 header string values consistently renamed with the
CamelJiraprefix. - Internal constants (
ACCESS_TOKEN,VERIFICATION_CODE,PRIVATE_KEY,CONSUMER_KEY,JIRA_REST_CLIENT_FACTORY) are correctly left unchanged — they are configuration keys, not Exchange headers. - Upgrade guide entry placed correctly under "Upgrading from 4.14.7 to 4.14.8" with a complete old→new mapping table and Endpoint DSL accessor rename list.
- Tests all reference headers via Java constants (
ISSUE_KEY,ISSUE_PROJECT_KEY, etc.), so no test changes needed — confirmed by inspecting the test sources on the branch. - Producer error messages updated to reference the new header names.
- Generated catalog JSON and Endpoint DSL
JiraHeaderNameBuilderare regenerated. - Component docs (
jira-component.adoc) updated; the staleIssueDescriptionheader references are correctly replaced with "The exchange body is used as the issue description" (no such constant existed). - Doc-sync PR for
main'scamel-4x-upgrade-guide-4_14.adocis tracked separately per the backport-upgrade-guide policy — noted in the PR description.
LGTM.
Claude Code on behalf of Guillaume Nodet
oscerd
added a commit
that referenced
this pull request
May 22, 2026
…4_14 and flag as potential breaking change (#23475) Doc-only sync of the camel-jira header-rename entry into camel-4x-upgrade-guide-4_18.adoc and _4_14.adoc on main (canonical history), mirroring backports #23460 / #23472. Also flags the 4.21 entry as a potential breaking change. Part of CAMEL-23577.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23417 onto
camel-4.14.x(target 4.14.8).Summary
Renames the Exchange header string values in
JiraConstantsfrom non-Camel-prefixed values (IssueKey,ProjectKey,IssueTransitionId,linkType,minutesSpent, …) toCamelJira<Name>, following the convention used across the rest of the Camel component catalog.ISSUE_KEY,ISSUE_PROJECT_KEY, …) are unchanged → routes referencing the constants symbolically keep working.JiraHeaderNameBuilderrenamed accordingly (issueKey()→jiraIssueKey(), …).Follows the rename pattern of CAMEL-23526 (
camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock). Part of the global sweep tracked by CAMEL-23577.Note on the upgrade guide
Per the project backport policy, the matching
camel-4x-upgrade-guide-4_14.adocentry onmainis synced in a separate doc-sync PR.Test plan
mvn -DskipTests installincomponents/camel-jiraon 4.14.x — catalog + docs regenerated cleanly; endpoint DSL regenerated.Reported by Claude Code on behalf of Andrea Cosentino