Fix ignored failOnError argument in DeleteEntityDataFetcher

[jamesfredley]

Summary

DeleteEntityDataFetcher.deleteInstance() called instance.delete(failOnError: true), but GORM's delete(Map) only honors the flush parameter - the failOnError argument is silently ignored. As a result the data fetcher gained no error-handling benefit from it.

This switches the call to instance.delete(flush: true), so the delete executes immediately and any failure (e.g. constraint violation, optimistic locking) is raised at that point and surfaces through the fetcher's existing try/catch to responseHandler.createResponse(env, false, exception). This matches the flush: true delete guidance documented in #15599.

Changes

• DeleteEntityDataFetcher: delete(failOnError: true) to delete(flush: true).
• DeleteEntityDataFetcherSpec: added an interaction test asserting deleteInstance calls delete(flush: true) and no longer passes the ignored failOnError argument.

Testing

./gradlew :grails-data-graphql-core:test --tests "org.grails.gorm.graphql.fetcher.impl.DeleteEntityDataFetcherSpec" --tests "org.grails.gorm.graphql.fetcher.impl.SoftDeleteEntityDataFetcherSpec"

All pass, including the existing happy-path / invalid-id cases and the SoftDeleteEntityDataFetcher (which overrides deleteInstance) regression check.

Flagged during review of #15599.

[Copilot]

Pull request overview

This pull request fixes DeleteEntityDataFetcher.deleteInstance() to use a GORM delete option that is actually honored, ensuring delete failures surface immediately and are handled by the existing try/catch response creation logic.

Changes:

• Updated DeleteEntityDataFetcher.deleteInstance() from delete(failOnError: true) to delete(flush: true) so the delete is executed/flushed immediately.
• Added a Spock interaction test to assert the fetcher calls delete(flush: true) and does not pass the ignored failOnError argument.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
grails-data-graphql/core/src/main/groovy/org/grails/gorm/graphql/fetcher/impl/DeleteEntityDataFetcher.groovy	Uses flush: true for deletes so failures surface at the delete point and can be captured by existing error handling.
grails-data-graphql/core/src/test/groovy/org/grails/gorm/graphql/fetcher/impl/DeleteEntityDataFetcherSpec.groovy	Adds an interaction test locking in the delete(flush: true) call and preventing regression to the ignored failOnError argument.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.