Skip to content

fix(client): Add SameNeighborsBatchApiTest to test suite #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sadwitdastreetz wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −0
Open

fix(client): Add SameNeighborsBatchApiTest to test suite #673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
879f18d
fix #672
sadwitdastreetz Jun 12, 2025
99ae31f
Merge branch 'master' into bugfix-branch
imbajin Jun 18, 2025
ae097cc
close #672
Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.apache.hugegraph.api.traverser.PersonalRankApiTest;
import org.apache.hugegraph.api.traverser.RingsRaysApiTest;
import org.apache.hugegraph.api.traverser.SameNeighborsApiTest;
import org.apache.hugegraph.api.traverser.SameNeighborsBatchApiTest;
import org.apache.hugegraph.api.traverser.ShortestPathApiTest;
import org.apache.hugegraph.api.traverser.SingleSourceShortestPathApiTest;
import org.apache.hugegraph.api.traverser.TemplatePathsApiTest;
Expand Down Expand Up @@ -74,6 +75,7 @@
CountApiTest.class,
RingsRaysApiTest.class,
SameNeighborsApiTest.class,
SameNeighborsBatchApiTest.class,

@VGalaxies VGalaxies Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High: Enabled test suite calls an unsupported server endpoint

hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:78

Evidence

  • SameNeighborsBatchAPI.type() returns sameneighborsbatch, so adding SameNeighborsBatchApiTest.class makes ApiTestSuite post to /traversers/sameneighborsbatch; the CI workflow runs ApiTestSuite against server commit 8c1ee71, where only SameNeighborsAPI at /traversers/sameneighbors exists.

Impact

  • mvn test -Dtest=ApiTestSuite will fail in CI once this class is included.

Requested fix

  • Align the client/test with the server route and response contract, or keep this test excluded until the CI server revision actually provides the batch endpoint.

@VGalaxies VGalaxies Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: Enabled limit coverage reuses a stale request

hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:78

Evidence

  • In SameNeighborsBatchApiTest.testSameNeighborsWithLimit(), the later limit(2L) and limit(1L) blocks create builders but post the original request built before those options were applied.

Impact

  • Even after the endpoint issue is fixed, the suite can pass without exercising batch limit behavior.

Requested fix

  • Rebuild and assign the request after setting each block’s options, then update the limit(1L) assertions to expect limited results.

JaccardSimilarityApiTest.class,
ShortestPathApiTest.class,
AllShortestPathsApiTest.class,
Expand Down
2 changes: 2 additions & 0 deletions ...ph-client/src/test/java/org/apache/hugegraph/api/traverser/SameNeighborsBatchApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@
import org.apache.hugegraph.testutil.Assert;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.Ignore;

import com.google.common.collect.ImmutableList;

@Ignore("Blocked by server: /traversers/sameneighborsbatch not implemented, see <https://github.com/apache/incubator-hugegraph/issues/2798>")

@imbajin imbajin Jul 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long

public class SameNeighborsBatchApiTest extends TraverserApiTest {

@BeforeClass
Expand Down
Loading