chore: update lombok version to 1.18.32 in pom.xml#715
Open
zxuexingzhijie wants to merge 2 commits into
Open
Conversation
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
VGalaxies
reviewed
Jun 24, 2026
VGalaxies
left a comment
VGalaxies
left a comment
Contributor
There was a problem hiding this comment.
Review summary
- Blocking: yes
- Summary: The Lombok version bump leaves release dependency and license metadata stale.
- Evidence:
git diff origin/master...HEAD- static inspection shows
pom.xml:132uses1.18.32, whileknown-dependencies.txtand releaseLICENSEstill reference1.18.8
| <junit.version>4.12</junit.version> | ||
| <mockito.version>2.25.1</mockito.version> | ||
| <lombok.version>1.18.8</lombok.version> | ||
| <lombok.version>1.18.32</lombok.version> |
Contributor
There was a problem hiding this comment.
Medium: Update release metadata for Lombok 1.18.32
pom.xml:132
Evidence
- The PR changes
<lombok.version>to1.18.32, buthugegraph-dist/scripts/dependency/known-dependencies.txt:249still listslombok-1.18.8.jar, andhugegraph-dist/release-docs/LICENSE:591still documentsorg.projectlombok:lombok:1.18.8. The license-checker workflow regenerates current dependencies and diffs them against the checked-in list.
Impact
- The dependency license check can fail, and release artifacts can ship incorrect third-party dependency/license metadata.
Requested fix
- Regenerate/update
hugegraph-dist/scripts/dependency/known-dependencies.txtand update the Lombok entry inhugegraph-dist/release-docs/LICENSEto1.18.32, including any related bundled license metadata if it changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hugegraph-client: Fatal error compiling: java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x20c71) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x20c71 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hugegraph-client
接下来是成功install后的