-
Notifications
You must be signed in to change notification settings - Fork 118
refactor(client): add graphRequired option in HugeClientBuilder #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
imbajin
merged 5 commits into
apache:master
from
FrostyHec:fix-hg-client-initialize-check
Apr 25, 2026
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0303b12
feat(client): add support for skipping required checks in HugeClientB…
FrostyHec 54e9430
Merge remote-tracking branch 'origin/master' into fix-hg-client-initi…
FrostyHec aa8044b
fix: update User.java formatting and enhance HugeClientBuilderTest wi…
FrostyHec f4a753b
refactor(client): replace skipRequiredChecks bool param with chainabl…
imbajin fa4146a
fix(client): update HugeClientHttpsTest assertions to match new error…
imbajin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
hugegraph-client/src/test/java/org/apache/hugegraph/unit/HugeClientBuilderTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package org.apache.hugegraph.unit; | ||
|
|
||
| import org.apache.hugegraph.driver.HugeClient; | ||
| import org.apache.hugegraph.driver.HugeClientBuilder; | ||
| import org.apache.hugegraph.rest.ClientException; | ||
|
FrostyHec marked this conversation as resolved.
Outdated
|
||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| public class HugeClientBuilderTest { | ||
|
|
||
| @Test | ||
| public void testBuilderWithSkipRequiredChecks() { | ||
| // Should not throw IllegalArgumentException when skipRequiredChecks is true and graph is null | ||
| HugeClientBuilder builder = new HugeClientBuilder("http://127.0.0.1:8080", "DEFAULT", null, true); | ||
| try { | ||
| builder.build(); | ||
| } catch (IllegalArgumentException e) { | ||
| Assert.fail("Should not throw IllegalArgumentException when skipRequiredChecks is true, but got: " + e.getMessage()); | ||
| } catch (Exception e) { | ||
| // Expected since there is probably no server running at localhost:8080 | ||
| // The fact we reach here means the bypass of graph/url check was successful. | ||
| } | ||
|
FrostyHec marked this conversation as resolved.
|
||
| } | ||
|
|
||
| @Test(expected = IllegalArgumentException.class) | ||
| public void testBuilderWithoutSkipRequiredChecks() { | ||
| // Should throw exception when skipRequiredChecks is false and graph is null | ||
| HugeClientBuilder builder = new HugeClientBuilder("http://127.0.0.1:8080", "DEFAULT", null, false); | ||
| builder.build(); | ||
| } | ||
|
FrostyHec marked this conversation as resolved.
|
||
|
|
||
| @Test | ||
| public void testHugeClientBuilderMethod() { | ||
| // Should not throw IllegalArgumentException | ||
| HugeClientBuilder builder = HugeClient.builder("http://127.0.0.1:8080", "DEFAULT", null, true); | ||
| try { | ||
| builder.build(); | ||
| } catch (IllegalArgumentException e) { | ||
| Assert.fail("Should not throw IllegalArgumentException when skipRequiredChecks is true, but got: " + e.getMessage()); | ||
| } catch (Exception e) { | ||
| // Expected | ||
| } | ||
| } | ||
|
|
||
| @Test(expected = IllegalArgumentException.class) | ||
| public void testHugeClientBuilderMethodWithoutSkip() { | ||
| // Should throw exception | ||
| HugeClientBuilder builder = HugeClient.builder("http://127.0.0.1:8080", "DEFAULT", null); | ||
| builder.build(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.