fix: fix inconsistent naming pattern#2945
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2945 +/- ##
============================================
- Coverage 35.61% 1.57% -34.04%
+ Complexity 333 43 -290
============================================
Files 801 779 -22
Lines 67533 65018 -2515
Branches 8780 8332 -448
============================================
- Hits 24053 1026 -23027
- Misses 40916 63906 +22990
+ Partials 2564 86 -2478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR enhances security for Arthas debugging endpoints by restricting remote access and standardizing configuration naming patterns across the codebase.
Changes:
- Added localhost-only access restriction to the store node's arthasstart endpoint
- Standardized Arthas configuration property names from snake_case to camelCase (e.g.,
arthas.telnet_port→arthas.telnetPort) - Changed default Arthas IP binding from
0.0.0.0to127.0.0.1and expanded disabled commands to includejad,ognl,vmtool
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| hugegraph-store/hg-store-node/src/main/resources/application.yml | Added Arthas configuration with localhost-only IP binding and expanded disabled commands |
| hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java | Added remote access check to arthasstart endpoint and new forbiddenMap helper method |
| hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/AppConfig.java | Updated default values for Arthas IP and disabled commands |
| hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties | Renamed Arthas properties to camelCase and updated default values |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java | Updated default values for Arthas IP binding and disabled commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
VGalaxies
left a comment
There was a problem hiding this comment.
Review summary
- Blocking: yes
- Summary: A success path can now throw while constructing the response because nullable payloads are passed into
Map.of(). - Evidence:
- Static review of
git diff origin/master...HEADandPartitionAPI.ok(...).
- Static review of
| cfIterator.close(); | ||
| }); | ||
| return okMap("ok", null); | ||
| return ok("ok", null); |
There was a problem hiding this comment.
High: Null success payloads now throw
hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java:174
Evidence
dumpPartition()returnsok("ok", null)here andcleanPartition()does the same at line 189, while the new helper buildsMap.of("status", 200, k, v)at line 238. JavaMap.of()rejects null keys or values and throwsNullPointerException.
Impact
GET /v1/partition/dump/{id}andGET /v1/partition/clean/{id}can return HTTP 500 after the operation succeeds; for clean, the data may already have been modified before response construction fails.
Requested fix
- Build the response with a nullable map implementation such as
HashMap/LinkedHashMap, or stop passing null values intook(...).
Currently, the configuration keys in rest-server.properties use snake_case (e.g., server_port), which is inconsistent with the naming convention expected by ServerOptions.java. This mismatch causes the following issues:
Terminal logs show warnings such as: "arthas.xxxx is redundant ...", indicating that the properties are not being recognized or registered.


