fix(core): keep unsafe range filters local#3068
Conversation
imbajin
left a comment
There was a problem hiding this comment.
Blocking: yes. The current head still misses the same unsafe range + connective label class for label-only or() filters. I verified this on a temporary detached worktree by adding a minimal regression traversal using or(__.hasLabel("el2"), __.hasLabel("el3")); the PR head still throws NoIndexException, while the existing and(__.hasLabel("el2")) regression passes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3068 +/- ##
============================================
- Coverage 36.57% 31.96% -4.62%
- Complexity 338 500 +162
============================================
Files 804 816 +12
Lines 68417 69738 +1321
Branches 8983 9226 +243
============================================
- Hits 25024 22291 -2733
- Misses 40706 44968 +4262
+ Partials 2687 2479 -208 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
imbajin
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: No obvious issues found in the current head. Evidence: git diff --check origin/master...HEAD; JDK 11 mvn -pl hugegraph-server/hugegraph-test -am -P core-test,rocksdb -Dtest=CountStrategyCoreTest,TraversalUtilOptimizeTest -DfailIfNoTests=false test passed 51 tests; latest-head checks passed.
Purpose of the PR
Main Changes
HugeGraphStepwhen followed by match/connective label filters.HasStepfilters.HasStep, so local filters are evaluated beforecount().Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need