Build: Add CI check to enforce runtime-deps.gradle coverage across all modules#16177
Open
kevinjqliu wants to merge 4 commits intoapache:mainfrom
Open
Build: Add CI check to enforce runtime-deps.gradle coverage across all modules#16177kevinjqliu wants to merge 4 commits intoapache:mainfrom
kevinjqliu wants to merge 4 commits intoapache:mainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
|
@RussellSpitzer wdyt? this should prevent future additions potentially missing the the runtime-deps.txt file |
Member
|
The original discussion I had with Ryan (he did your approach) is I just thought it would be easier to maintain the 'needs check list' then the 'ignore list' . I don't have strong feelings |
Contributor
Author
|
@rdblue thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
verifyRuntimeDepsAppliedtask that fails CI if a subproject is missingruntime-deps.gradleand is not in an explicit exclusion list. This prevents newshadow JAR modules from being added without dependency tracking.
Changes
verifyRuntimeDepsAppliedtask tobuild.gradlewith an exclusion list ofmodules that don't ship fat JARs
checkAllRuntimeDepsso it runs in CI automaticallyruntime-deps.gradleHow it works
Every subproject must either:
runtime-deps.gradle(produces acheckRuntimeDepstask), orIf a new module is added without doing either, CI fails with a message naming
the uncovered module and instructions to fix it.
Testing
./gradlew checkAllRuntimeDeps -q -DallModules=truepassesruntime-deps.gradlefromaws-bundle