Build: Strict runtime-deps check and auto-regeneration for dependabot PRs#16233
Open
kevinjqliu wants to merge 2 commits intoapache:mainfrom
Open
Build: Strict runtime-deps check and auto-regeneration for dependabot PRs#16233kevinjqliu wants to merge 2 commits intoapache:mainfrom
kevinjqliu wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
i was surprised by the drift in runtime-deps.txt, @RussellSpitzer wydt about this pattern to autoupdate for dependabot? |
Member
|
@kevinjqliu Ryan and I discussed this in the previous work. Rather than letting dependapot automatically change the deps (or raise the change) we just decided to ignore patch updates. I still record them though so it may make sense to remove them |
Member
|
I think I would vote that we just drop the patch's from the dependency text to avoid the churn there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkRuntimeDepspreviously ignored patch-level version changes (e.g. 5.6.0 → 5.6.1), allowing staleruntime-deps.txtbaselines to pass CI. This caused PRs like #16204 to merge without updating the baselines.Changes
runtime-deps.gradle: Remove patch tolerance — compare exact versions so any mismatch fails the build..github/workflows/autoupdate-runtime-deps.yml(new): Auto-regenerate and commitruntime-deps.txton dependabot PRs that modifygradle/libs.versions.toml.Testing
checkRuntimeDepsfails on a patch-level version mismatch (httpclient5 5.6.0 vs 5.6.1).checkAllRuntimeDepspasses with current baselines.