refactor(FQDN): further more refator on idl/dsn.layer2.thrift v2#2217
Merged
acelyc111 merged 7 commits intoapache:masterfrom May 21, 2025
Merged
refactor(FQDN): further more refator on idl/dsn.layer2.thrift v2#2217acelyc111 merged 7 commits intoapache:masterfrom
acelyc111 merged 7 commits intoapache:masterfrom
Conversation
42503a1 to
02eef41
Compare
acelyc111
reviewed
Apr 13, 2025
Member
acelyc111
left a comment
There was a problem hiding this comment.
@Samunroyu pls check the failed tests, thanks!
There was a problem hiding this comment.
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/meta/server_state_restore.cpp:258
- The implicit boolean check on 'primary' may be ambiguous if host_port does not clearly define a boolean conversion. Consider explicitly checking whether 'primary' is set or valid (e.g., comparing against a default host_port instance).
if (primary || !secondaries.empty()) {
src/meta/meta_bulk_load_service.cpp:479
- [nitpick] The temporary variable 'primary' used here could be confused with other primary values in the context; consider renaming it to a more descriptive name such as 'extracted_primary' for clarity.
GET_HOST_PORT(request, primary, primary_hp);
src/meta/duplication/meta_duplication_service.cpp:771
- Relying on an implicit boolean check on 'primary' might lead to ambiguity; explicitly verify if 'primary' is valid or set to its default value to ensure correct behavior.
if (!primary) {
acelyc111
reviewed
Apr 23, 2025
acelyc111
previously approved these changes
May 8, 2025
empiredan
reviewed
May 9, 2025
empiredan
approved these changes
May 21, 2025
acelyc111
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a further refactor on idl/dsn.layer2.thrift based on #2049
the main effects are on partition_configuration structure.