Skip to content

chore: add comments to C++ client to adapt Doxygen#2233

Open
acelyc111 wants to merge 13 commits intoapache:masterfrom
acelyc111:cpp_doxgen
Open

chore: add comments to C++ client to adapt Doxygen#2233
acelyc111 wants to merge 13 commits intoapache:masterfrom
acelyc111:cpp_doxgen

Conversation

@acelyc111
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the docs label Jan 29, 2026
@acelyc111 acelyc111 marked this pull request as ready for review January 29, 2026 16:46
Copilot AI review requested due to automatic review settings January 29, 2026 16:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the Pegasus C++ client easier to document with Doxygen by adding Doxygen-friendly comments and introducing a Doxygen config/guide under src/client_lib/doxygen/.

Changes:

  • Added extensive Doxygen comment blocks to C++ client headers (pegasus_client_impl.h, pegasus_client_factory_impl.h).
  • Added a Doxygen configuration file and a short generation guide under src/client_lib/doxygen/.
  • Introduced a Doxygen group (pegasus_cpp_client) and file-level @file headers.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
src/client_lib/pegasus_client_impl.h Adds Doxygen file header, group tags, and API comments across client/scanner declarations.
src/client_lib/pegasus_client_factory_impl.h Adds Doxygen file header, group tags, and factory method documentation.
src/client_lib/doxygen/README.md Adds instructions for generating Doxygen docs.
src/client_lib/doxygen/Doxyfile Adds a Doxygen configuration targeting the C++ client headers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/client_lib/pegasus_client_factory_impl.h Outdated
Comment thread src/client_lib/pegasus_client_impl.h Outdated
Comment thread src/client_lib/pegasus_client_impl.h Outdated
Comment thread src/client_lib/pegasus_client_impl.h Outdated
Comment thread src/client_lib/pegasus_client_impl.h Outdated
Comment thread src/client_lib/doxygen/README.md
Comment thread src/client_lib/doxygen/README.md Outdated
Comment thread src/client_lib/doxygen/Doxyfile Outdated
Comment thread src/client_lib/pegasus_client_impl.h Outdated
Comment thread src/client_lib/pegasus_client_impl.h Outdated
acelyc111 and others added 9 commits January 30, 2026 23:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants