build: restrict the CMake version installed on Ubuntu 20.04 and 22.04 to 3.x.x#2245
Merged
build: restrict the CMake version installed on Ubuntu 20.04 and 22.04 to 3.x.x#2245
CMake version installed on Ubuntu 20.04 and 22.04 to 3.x.x#2245Conversation
acelyc111
approved these changes
May 10, 2025
foreverneverer
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2244.
The reason for failing to build
thirdparties-src-*images is that theCMakeversionis too new (currently 4.0.0) in the build environment for both Ubuntu 20.04 and 22.04,
while some third-party dependencies still rely on older
CMake syntax, e.g.thrift-0.9.3declares
cmake_minimum_required(VERSION 2.8.12)in itsCMakeLists.txt. Such legacysyntax is not fully compatible with the newest versions of
CMake.To solve this problem, we restrict the
CMakeversion installed in the Ubuntu 20.04 and22.04 environments to a newer 3.x.x version that
also maintains compatibility with legacy
CMakeLists.txtfiles.