fix(shell): make the returned scanners sorted in ascending order by partition index to support fetching specified partition in shell#2312
Merged
acelyc111 merged 2 commits intoapache:masterfrom Nov 4, 2025
Conversation
… does not correctly correspond to the table's partition_id
limowang
force-pushed
the
scanner
branch
7 times, most recently
from
9d396a6 to
9f5e5d0
Compare
limowang
changed the title
limowang
changed the title
empiredan
reviewed
Oct 31, 2025
limowang
force-pushed
the
scanner
branch
2 times, most recently
from
f98ff0e to
40abec2
Compare
empiredan
approved these changes
Nov 3, 2025
empiredan
changed the title
acelyc111
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2309.
This pull request updates the logic for assigning partition indices in the
async_get_unordered_scannersmethod ofpegasus_client_impl.cpp.The change ensures that each scanner receives a unique and sequential
partition index, rather than decrementing from the total count, when the
variable max_split_count is greater than the number of partitions in the
table.
Partition assignment logic update:
to use an incrementing
partition_indexvariable, ensuring unique andsequential indices for each partition instead of using a decrementing
countvalue.