fix: avoid reopening GC-deleted plog during duplication#2373
Merged
acelyc111 merged 11 commits intoapache:masterfrom Mar 13, 2026
Merged
fix: avoid reopening GC-deleted plog during duplication#2373acelyc111 merged 11 commits intoapache:masterfrom
acelyc111 merged 11 commits intoapache:masterfrom
Conversation
added 2 commits
February 12, 2026 20:22
Fix apache#2372. Duplication replay may access private log files deleted by concurrent GC. Track cleanable decree and stop scanning plog files beyond GC boundary to prevent crash.
added 5 commits
February 12, 2026 20:46
Prevent unintended copying and moving of mutation_log_private instances by deleting the corresponding constructors and assignment operators. Additionally, update the method signature for find_log_file_to_start to improve clarity.
empiredan
reviewed
Mar 10, 2026
added 3 commits
March 11, 2026 16:06
empiredan
approved these changes
Mar 13, 2026
acelyc111
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2372.
Duplication replay may access private log files deleted by
concurrent GC. Track cleanable decree and stop scanning
plog files beyond GC boundary to prevent crash.