Skip to content

Avoid double-counting Automaton in CompiledAutomaton.ramBytesUsed #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reugn wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Avoid double-counting Automaton in CompiledAutomaton.ramBytesUsed #16046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366f255
Avoid double-counting Automaton in CompiledAutomaton.ramBytesUsed
reugn May 10, 2026
99f0f4a
Add changelog entry
reugn May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ Bug Fixes

* GITHUB#15939: Fix thread-safety issues with NFARunAutomaton. (Dimitris Rempapis)

* GITHUB#16046: Fix double-counting of underlying Automaton in CompiledAutomaton#ramBytesUsed. (Eugene Rizhkov)

Changes in Runtime Behavior
---------------------
* GITHUB#14187: The query cache is now disabled by default. (Adrien Grand)
Expand Down
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,8 @@ public boolean equals(Object obj) {

@Override
public long ramBytesUsed() {
// this.automaton is accounted via runAutomaton.ramBytesUsed()
return BASE_RAM_BYTES
+ RamUsageEstimator.sizeOfObject(automaton)
+ RamUsageEstimator.sizeOfObject(commonSuffixRef)
+ RamUsageEstimator.sizeOfObject(runAutomaton)
+ RamUsageEstimator.sizeOfObject(nfaRunAutomaton)
Expand Down
Loading