Skip to content

Simplify SortedDocIDMerger.next() #16073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tim-Brooks wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −1
Open

Simplify SortedDocIDMerger.next() #16073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0d0ec7
Remove dead code and simplify SortedDocIDMerger
Tim-Brooks May 15, 2026
df45266
Change
Tim-Brooks May 15, 2026
c11005d
Changes
Tim-Brooks May 15, 2026
9dfe00f
Merge remote-tracking branch 'upstream/main' into doc_id_merge_clean-ups
Tim-Brooks May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,8 @@ Other

* GITHUB#15960: Move parent field from DWPT to IndexingChain. (Tim Brooks)

* GITHUB#16073: Simplify SortedDocIDMerger.next(). (Tim Brooks)

======================= Lucene 10.4.0 =======================

API Changes
Expand Down
4 changes: 3 additions & 1 deletion lucene/core/src/java/org/apache/lucene/index/DocIDMerger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ public T next() throws IOException {
} else {
current = queue.pop();
}
} else if (queue.size() > 0) {
} else {
// queue cannot be empty here: if it were, queueMinDocID == NO_MORE_DOCS, and any valid
// nextDoc would satisfy nextDoc < queueMinDocID, taking the fast path above
assert queueMinDocID == queue.top().mappedDocID;
assert nextDoc > queueMinDocID;
T newCurrent = queue.top();
Expand Down
Loading