Skip to content

[maven-4.0.x] Filter transitive repositories with uninterpolated IDs (#12049)#12070

Merged
gnodet merged 1 commit into
maven-4.0.xfrom
backport-12049-to-4.0.x
May 19, 2026
Merged

[maven-4.0.x] Filter transitive repositories with uninterpolated IDs (#12049)#12070
gnodet merged 1 commit into
maven-4.0.xfrom
backport-12049-to-4.0.x

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented May 18, 2026

Summary

Backport of #12050 to maven-4.0.x.

  • Extend the transitive repository filter in mergeRepositories to also exclude repositories whose ID contains uninterpolated expressions (${...}), not just URLs
  • Add test coverage for repositories with uninterpolated IDs but valid URLs

Fixes #12049

Claude Code on behalf of Guillaume Nodet

The existing filter in mergeRepositories already excluded transitive
repositories with uninterpolated URLs but did not check repository IDs.
When a transitive dependency POM contained an expression like
${eclipseP2RepoId} as a repository ID with a valid URL, it passed the
filter and later caused MavenValidator to throw IllegalArgumentException.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gnodet gnodet force-pushed the backport-12049-to-4.0.x branch from 38b4203 to dd67f6b Compare May 19, 2026 09:05
@gnodet gnodet added this to the 4.0.0-rc-6 milestone May 19, 2026
@gnodet gnodet merged commit 6b42a8e into maven-4.0.x May 19, 2026
23 checks passed
@gnodet gnodet deleted the backport-12049-to-4.0.x branch May 19, 2026 11:51
@github-actions
Copy link
Copy Markdown

@gnodet Please assign appropriate label to PR according to the type of change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant