Fix #12074: prevent false parent cycle with shade plugin's dependency-reduced-pom.xml#12079
Merged
Merged
Conversation
This was referenced May 18, 2026
…ndency-reduced-pom.xml In readParentLocally(), the GA mismatch check ran after readAsParentModel() which recursively resolves the candidate's parent chain. When a generated POM (e.g., dependency-reduced-pom.xml) sits alongside the project POM and the default relative path resolves to the wrong POM, the recursive resolution adds the shared parent's model ID to the chain — triggering a false cycle. Move the GA check before the recursive call by reading only the file model first. This matches the behavior of the Maven 3 model builder which checked GA before recursing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gnodet
force-pushed
the
backport-12074-to-4.0.x
branch
from
9dd7603 to
a404c0d
Compare
gnodet
added a commit
that referenced
this pull request
May 19, 2026
gnodet
added a commit
that referenced
this pull request
May 19, 2026
rmannibucau
approved these changes
May 19, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #12078 to
maven-4.0.x.dependency-reduced-pom.xmlfrom shade plugin) has a parent whose default relative path resolves to a POM with a different GA but the same parent referencereadAsParentModel()call by reading the file model first, matching the Maven 3 model builder's behaviorTest plan
testNoFalseCycleWhenRelativePathResolvesToWrongPominParentCycleDetectionTestmaven-4.0.xFixes #12074
Claude Code on behalf of Guillaume Nodet