[maven-4.0.x] fix: propagate addResource() to model Build for Maven 3 compat#12093
Merged
Conversation
When a Maven 3 plugin dynamically adds a resource via project.addResource() or project.getResources().add(), the resource was only added to the internal sources set but not to the model's Build.resources. This caused project.getBuild().getResources() to be out of sync with project.getResources(), breaking plugins like maven-source-plugin that access resources through the Build model. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Also sync the model's Build.resources after project building so that project.getBuild().getResources() is consistent with project.getResources() even when resources are defined via <sources> (Maven 4.1.0 model) rather than legacy <resources>. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Avoid syncing Build.resources for legacy projects to prevent Path.toString() from converting forward slashes to backslashes on Windows (fixes PomConstructionTest.testTargetPathResourceRegression). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
May 19, 2026
rmannibucau
approved these changes
May 19, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11868 to
maven-4.0.x.Propagate
addResource()/addTestResource()calls on the modelBuildobject to the underlyingSourcesset for Maven 3 compatibility. Also ensuresBuild.resourcesis properly synced from theSourcesset for<sources>projects.Claude Code on behalf of Guillaume Nodet