HDDS-15165. Recon: Add admin REST APIs to trigger, monitor, and cancel SCM DB snapshot sync.#10186
Open
devmadhuu wants to merge 3 commits intoapache:masterfrom
Open
HDDS-15165. Recon: Add admin REST APIs to trigger, monitor, and cancel SCM DB snapshot sync.#10186devmadhuu wants to merge 3 commits intoapache:masterfrom
devmadhuu wants to merge 3 commits intoapache:masterfrom
Conversation
added 2 commits
May 4, 2026 22:18
sumitagrawl
reviewed
May 6, 2026
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@devmadhuu given few comment
| synchronized (scmSnapshotLock) { | ||
| scmSnapshotTaskStarted = true; | ||
| } | ||
| DBCheckpoint dbSnapshot = scmServiceProvider.getSCMDBSnapshot(); |
Contributor
There was a problem hiding this comment.
a check is required here if cancelled or not, as there is a chance of cancel marked cancel, and set isSyncDataFromSCMRunning to false. But its still running waiting in synchronized block. This check should be added in synchronized block
This needs to be done before starting sync db from scm
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for catching this race condition. Yes I fixed it now.
| } else { | ||
| LOG.error("Null snapshot location got from SCM."); | ||
| try { | ||
| updateReconSCMDBWithNewSnapshotWithoutGuard(); |
Contributor
There was a problem hiding this comment.
do startup sync and trigger can have some conflict ?
Contributor
Author
There was a problem hiding this comment.
Yes . fixed it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change adds Recon admin REST APIs to explicitly manage full SCM DB snapshot syncs as a follow-up to #10074.
The new APIs are exposed under
TriggerDBSyncEndpoint:The implementation keeps full SCM snapshot recovery as an explicit admin action instead of coupling it to periodic SCM container sync. It tracks snapshot sync lifecycle state in
ReconStorageContainerManagerFacade, prevents concurrent SCM DB sync operations, allows cancellation only before DB initialization starts, and cleans up failed or cancelled checkpoint directories.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15165
How was this patch tested?
Tests were added for the new trigger/status/cancel endpoint behavior in
TestTriggerDBSyncEndpoint.