Skip to content

HDDS-15181. Added Robot smoketests for snapshot defrag on single-node compose #10200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunsarin85 wants to merge 2 commits into
base: master
Choose a base branch
from
+127 −0
Open

HDDS-15181. Added Robot smoketests for snapshot defrag on single-node compose #10200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae498c
HDDS-15181. Added Robot smoketests for snapshot defrag on single-node…
arunsarin85 May 6, 2026
4fffa8c
HDDS-15181. Addressed review comments
arunsarin85 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hadoop-ozone/dist/src/main/compose/ozone/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ services:
<<: *common-config
environment:
ENSURE_OM_INITIALIZED: /data/metadata/om/current/VERSION
# OM-only: periodic snapshot defrag for smoketest snapshot/snapshot-defrag.robot (HDDS-15181)
OZONE-SITE.XML_ozone.snapshot.defrag.service.interval: 30s
Comment thread
arunsarin85 marked this conversation as resolved.
Outdated
OZONE_OPTS:
<<: *replication
ports:
Expand Down
106 changes: 106 additions & 0 deletions hadoop-ozone/dist/src/main/smoketest/snapshot/snapshot-defrag.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

*** Settings ***
Documentation Basic checks that snapshots still look correct while the OM runs periodic
... snapshot defrag in the background (Jira HDDS-15181 / parent HDDS-13003).
... Cluster setup: filesystem snapshots on; defrag interval on the OM only
... (compose/ozone docker-compose).
Library OperatingSystem
Resource ../ozone-lib/shell.robot
Resource snapshot-setup.robot
Suite Setup Prepare Suite With Bucket And First Snapshot
Test Timeout 20 minutes

*** Variables ***
# Wait long enough for at least two defrag runs (OM uses a 30s interval in compose).
${DEFRAG_WAIT_SECONDS} 65

*** Test Cases ***
Read Snapshot Data Right After Create
[Documentation] You can read the snapshotted key from the .snapshot path as soon as the snapshot exists.
Key Should Match Local File ${SNAP_KEY_PATH_ONE} /etc/hosts

After Waiting Keys Still Match Through Snapshot And On Live Bucket
[Documentation] Add a new key on the live bucket, wait so defrag may run, then confirm the snapshot
... still has the old file and the live bucket has the new one.
${key_two} = snapshot-setup.Create key ${VOLUME} ${BUCKET} /etc/passwd
Set Suite Variable ${KEY_TWO} ${key_two}
Set Suite Variable ${LIVE_KEY_TWO_PATH} /${VOLUME}/${BUCKET}/${key_two}
Sleep ${DEFRAG_WAIT_SECONDS}
Key Should Match Local File ${SNAP_KEY_PATH_ONE} /etc/hosts
Key Should Match Local File ${LIVE_KEY_TWO_PATH} /etc/passwd

Snapshot List Still Shows Active
[Documentation] ozone sh snapshot ls still lists this snapshot as SNAPSHOT_ACTIVE.
${result} = Execute ozone sh snapshot ls /${VOLUME}/${BUCKET}
Should contain ${result} ${SNAPSHOT_ONE}
Should contain ${result} SNAPSHOT_ACTIVE

Second Snapshot Sees All Keys So Far
[Documentation] Take another snapshot after adding a third key; older snapshot still only has the first key;
... newer snapshot can read all three keys.
${key_three} = snapshot-setup.Create key ${VOLUME} ${BUCKET} /etc/group
Set Suite Variable ${KEY_THREE} ${key_three}
${snapshot_two} = Create snapshot ${VOLUME} ${BUCKET}
Set Suite Variable ${SNAPSHOT_TWO} ${snapshot_two}
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_ONE}/${KEY_ONE} /etc/hosts
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_ONE} /etc/hosts
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_TWO} /etc/passwd
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_THREE} /etc/group

Snapshot Diff Starts A New Job
[Documentation] Comparing the two snapshots prints the usual “new job” and --get-report hint (like snapshot-sh.robot).
${result} = Execute ozone sh snapshot diff /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} ${SNAPSHOT_TWO}
Should contain ${result} Submitting a new job
Should contain ${result} --get-report option

Snapshot Diff Json Report Lists Added Keys
[Documentation] Full JSON report finishes with DONE and lists the keys that appeared after the first snapshot.
${result} = Execute ozone sh snapshot diff --get-report --json /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} ${SNAPSHOT_TWO}
Should contain echo '${result}' | jq '.jobStatus' DONE
Should contain echo '${result}' | jq '.snapshotDiffReport.volumeName' ${VOLUME}
Should contain echo '${result}' | jq '.snapshotDiffReport.bucketName' ${BUCKET}
Should contain echo '${result}' | jq '.snapshotDiffReport.fromSnapshot' ${SNAPSHOT_ONE}
Should contain echo '${result}' | jq '.snapshotDiffReport.toSnapshot' ${SNAPSHOT_TWO}
Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_TWO}
Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_THREE}

Snapshot Diff Json Unchanged After Another Defrag Wait
Comment thread
smengcl marked this conversation as resolved.
Outdated
[Documentation] Run the same JSON diff again after waiting again; the reported key paths should still be there.
Sleep ${DEFRAG_WAIT_SECONDS}
Comment thread
smengcl marked this conversation as resolved.
Copy link
Copy Markdown
Contributor

@smengcl smengcl May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a step around here to check the YAML to confirm defrag completion, something like this:

*** Keywords ***
Get Snapshot Local YAML Path
    [Arguments]    ${snapshot_name}
    ${info} =          Execute    ozone sh snapshot info /${VOLUME}/${BUCKET} ${snapshot_name}
    ${snapshot_id} =   Execute    echo '${info}' | jq -r '.snapshotId'
    [Return]           /data/metadata/db.snapshots/checkpointState/om.db-${snapshot_id}.yaml

Snapshot Local YAML Should Show Defragged
    [Arguments]    ${snapshot_name}
    ${yaml} =          Get Snapshot Local YAML Path    ${snapshot_name}
    Execute            test -f ${yaml}
    ${version} =       Execute    awk '/^version:/ {print $2}' ${yaml}
    ${needs_defrag} =  Execute    awk '/^needsDefrag:/ {print $2}' ${yaml}
    Should Be True     ${version} > 0
    Should Be Equal    ${needs_defrag}    false

Copy link
Copy Markdown
Contributor

@smengcl smengcl May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually with this, you can poll rather than waiting for fixed amount of time, so as to make the test finish quicker.

${result} = Execute ozone sh snapshot diff --get-report --json /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} ${SNAPSHOT_TWO}
Should contain echo '${result}' | jq '.jobStatus' DONE
Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_TWO}
Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_THREE}

Delete Older Snapshot Younger One Still Readable
[Documentation] Delete the first snapshot; it shows SNAPSHOT_DELETED; read all keys through the second snapshot path.
${output} = Execute ozone sh snapshot delete /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE}
Should not contain ${output} Failed
${output} = Execute ozone sh snapshot ls /${VOLUME}/${BUCKET} | jq '[.[] | select(.name == "${SNAPSHOT_ONE}") | .snapshotStatus] | if length > 0 then .[] else "SNAPSHOT_DELETED" end'
Should contain ${output} SNAPSHOT_DELETED
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_ONE} /etc/hosts
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_TWO} /etc/passwd
Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_THREE} /etc/group

*** Keywords ***
Prepare Suite With Bucket And First Snapshot
Setup volume and bucket
${key_one} = snapshot-setup.Create key ${VOLUME} ${BUCKET} /etc/hosts
Set Suite Variable ${KEY_ONE} ${key_one}
${snapshot_one} = Create snapshot ${VOLUME} ${BUCKET}
Set Suite Variable ${SNAPSHOT_ONE} ${snapshot_one}
Set Suite Variable ${SNAP_KEY_PATH_ONE} /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${snapshot_one}/${key_one}