fix(tls): log transient SSL factory renewal failures at WARN instead of INFO#18403
Open
dkranchii wants to merge 1 commit intoapache:masterfrom
Open
fix(tls): log transient SSL factory renewal failures at WARN instead of INFO#18403dkranchii wants to merge 1 commit intoapache:masterfrom
dkranchii wants to merge 1 commit intoapache:masterfrom
Conversation
…ry renewal failures in RenewableTlsUtils
Transient failures in reloadSslFactory (e.g. cert files mid-rotation)
were silently swallowed at INFO level, making them invisible to
operators who rely on WARN/ERROR dashboards to detect TLS issues.
Changed LOGGER.info to LOGGER.warn in the retry catch block so that
each transient failure is surfaced at the appropriate level. Also
improved the message from the truncated "...truststore {}) on " to
"...truststore {}), retrying if attempts remain" — neutral wording that
remains accurate on the final exhausted attempt, before the existing
LOGGER.error fires.
dbcc287 to
a63fb42
Compare
Contributor
Author
|
@Jackie-Jiang can you review this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18403 +/- ##
=========================================
Coverage 63.46% 63.46%
Complexity 1701 1701
=========================================
Files 3254 3254
Lines 199104 199104
Branches 30830 30830
=========================================
+ Hits 126354 126366 +12
+ Misses 62665 62650 -15
- Partials 10085 10088 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the log level from
INFOtoWARNin the retry catch block ofRenewableTlsUtils.reloadSslFactory, so transient SSL renewal failuresare visible to anyone monitoring at
WARN+(which is most prod logpipelines).
Also tightens the message: the old text ended with
"... truststore {}) on "which looked truncated. The new wording stays accurate even on the
final retry, so it doesn't contradict the
LOGGER.errorthat firesright after when all 3 attempts fail.
Diff
Scope
Single file: pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java
No behavior change, no config / SPI / wire-format change
Testing
Existing RenewableTlsUtilsTest still passes (catch block isn't currently covered by a test, so no test changes needed).
Manually verified the new message renders correctly when an exception is thrown — the SLF4J trailing Throwable argument still produces the full stack trace.
Release note
none (observability-only change)
Fixes #18402