Fix spacing in SeaTunnel Tools section of README#11372
Conversation
Corrected spacing in README.md for better readability.
DanielLeens
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! I checked the latest head and this is a safe README-only formatting fix.
What this PR changes:
README Tools section
-> "etc,please" becomes "etc, please"
-> the SeaTunnel Tools link stays unchanged
-> no runtime code, connector config, docs contract, or engine path is affected
I did a source-level review only and did not run local build/tests, because this PR changes one README sentence and does not touch runnable code.
Merge conclusion: source/docs side looks good to me, but I cannot approve yet because the current Build check is still ACTION_REQUIRED: https://github.com/apache/seatunnel/runs/85611091635
Could you please make sure the workflow for this PR/fork is enabled or approved, then rerun the Build check? Once that check is green, this should be ready from Daniel's side.
|
@DanielLeens Hi, I've enabled GitHub Actions, synced my branch, and pushed an empty commit to trigger the CI. The Build check still shows "required action". Could you please help approve the workflow? Thanks! |
DanielLeens
left a comment
There was a problem hiding this comment.
Thanks for the update. I re-reviewed the latest head.
What this PR fixes
- User pain point: the README sentence under Apache SeaTunnel Tools had a small spacing typo.
- Fix approach: change
etc,pleasetoetc, please. - In one sentence: this is a tiny README readability fix.
Review path checked
User opens README
-> reads the Apache SeaTunnel Tools section
-> the sentence now has the expected space after the comma
This is README-only. It does not affect runtime code, APIs, options, defaults, protocol, serialization, logging, resources, or compatibility.
Testing and local verification
- Checked the README diff: only the spacing change is present.
- I did not run local tests because this is a documentation-only one-line change.
Issues
No source-level blockers found.
Merge conclusion
Conclusion: can merge after CI/workflow gate
Blocking items: none from the source/docs review.
Non-blocking suggestions: none.
The remaining gate is still the Build workflow in ACTION_REQUIRED state. Please enable/approve the workflow and rerun the check; once it is green, this looks good from my side.
|
Rechecked the current head Runtime path recheckedMerge conclusionConclusion: source blocker cleared from Daniel's side; sync latest
|
Corrected spacing in README.md for better readability.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.