Skip to content

Fix spacing in SeaTunnel Tools section of README#11372

Open
jinniiii233 wants to merge 2 commits into
apache:devfrom
jinniiii233:patch-2
Open

Fix spacing in SeaTunnel Tools section of README#11372
jinniiii233 wants to merge 2 commits into
apache:devfrom
jinniiii233:patch-2

Conversation

@jinniiii233

Copy link
Copy Markdown

Corrected spacing in README.md for better readability.

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Corrected spacing in README.md for better readability.
@davidzollo davidzollo added the First-time contributor First-time contributor label Jul 7, 2026

@DanielLeens DanielLeens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! I checked the latest head and this is a safe README-only formatting fix.

What this PR changes:

README Tools section
  -> "etc,please" becomes "etc, please"
  -> the SeaTunnel Tools link stays unchanged
  -> no runtime code, connector config, docs contract, or engine path is affected

I did a source-level review only and did not run local build/tests, because this PR changes one README sentence and does not touch runnable code.

Merge conclusion: source/docs side looks good to me, but I cannot approve yet because the current Build check is still ACTION_REQUIRED: https://github.com/apache/seatunnel/runs/85611091635

Could you please make sure the workflow for this PR/fork is enabled or approved, then rerun the Build check? Once that check is green, this should be ready from Daniel's side.

@jinniiii233

Copy link
Copy Markdown
Author

@DanielLeens Hi, I've enabled GitHub Actions, synced my branch, and pushed an empty commit to trigger the CI. The Build check still shows "required action". Could you please help approve the workflow? Thanks!

@DanielLeens DanielLeens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I re-reviewed the latest head.

What this PR fixes

  • User pain point: the README sentence under Apache SeaTunnel Tools had a small spacing typo.
  • Fix approach: change etc,please to etc, please.
  • In one sentence: this is a tiny README readability fix.

Review path checked

User opens README
  -> reads the Apache SeaTunnel Tools section
      -> the sentence now has the expected space after the comma

This is README-only. It does not affect runtime code, APIs, options, defaults, protocol, serialization, logging, resources, or compatibility.

Testing and local verification

  • Checked the README diff: only the spacing change is present.
  • I did not run local tests because this is a documentation-only one-line change.

Issues

No source-level blockers found.

Merge conclusion

Conclusion: can merge after CI/workflow gate

Blocking items: none from the source/docs review.
Non-blocking suggestions: none.

The remaining gate is still the Build workflow in ACTION_REQUIRED state. Please enable/approve the workflow and rerun the check; once it is green, this looks good from my side.

@DanielLeens

Copy link
Copy Markdown
Contributor

Rechecked the current head 9b7a7f76d848 against the latest dev after the CI / merge-gate fact changed.

Runtime path rechecked

User opens README
  -> reads the Apache SeaTunnel Tools section
      -> the sentence now has the expected space after the comma

Merge conclusion

Conclusion: source blocker cleared from Daniel's side; sync latest dev and rerun CI first

  1. Blocking items
  1. Lowest-cost next step
  • Please sync with the latest dev and rerun the failing gate first.
  • If it still fails on the updated head, I can help narrow down the new failure from there.

Daniel only has READ permission on this repository, so a write-capable maintainer may still need to handle the final approval / dismissal step once the gate is clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants