feat(c/sedona-extension): Implement FFI wrapper for ArrowAsyncProducer API#914
Draft
paleolimbot wants to merge 16 commits into
Draft
feat(c/sedona-extension): Implement FFI wrapper for ArrowAsyncProducer API#914paleolimbot wants to merge 16 commits into
paleolimbot wants to merge 16 commits into
Conversation
30a72a5 to
a8089ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress...this was largely generated and I keep catching lazy things the LLM did. In particular I think we need some more wrapper structs to ensure lifecycles stay in check. We don't need this quite yet but I wanted to put this up to point to.
The high-level goal is to implement an FFI wrapper around the SendableRecordBatchStream. DataFrames are, in essence, n asynchronous streams with some properties. The properties are more straightforward to sync across a boundary but the async stream is key to performance and the async interaction is complicated.
The Arrow Async Device interface was merged some time ago, mostly targeted at GPU interactions. However, care was taken at the time to ensure this could characterize a variety of asynchronous interactions. With repsect to sedona extensions, it means that we can write all async-critical interactions in terms of a record batch stream so we only have to deal with this interaction once.