[SPARK-56755][SQL][TESTS][FOLLOWUP][4.0] Fix ShowCreateTableSuite#55791
Closed
pan3793 wants to merge 1 commit into
Closed
[SPARK-56755][SQL][TESTS][FOLLOWUP][4.0] Fix ShowCreateTableSuite#55791pan3793 wants to merge 1 commit into
pan3793 wants to merge 1 commit into
Conversation
A follow-up of the backport (apache#55718) to fix the test - SPARK-55372 (4.2.0) changed the output of `SHOW CREATE TABLE ...` output for `STRING` columns, it does not go to branch-4.1, so the test case should be modified. Fix tests. No. ``` $ build/sbt "sql/testOnly *ShowCreateTableSuite" [info] Run completed in 11 seconds, 832 milliseconds. [info] Total number of tests run: 46 [info] Suites: completed 2, aborted 0 [info] Tests: succeeded 46, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 304 s (0:05:04.0), completed May 9, 2026, 5:36:26 PM ``` No. Closes apache#55780 from pan3793/SPARK-56755-4.1. Authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
approved these changes
May 11, 2026
pan3793
added a commit
that referenced
this pull request
May 11, 2026
Port #55780 to branch-4.0 ### What changes were proposed in this pull request? A follow-up of the backport (#55718) to fix the test - SPARK-55372 (4.2.0) changed the output of `SHOW CREATE TABLE ...` output for `STRING` columns, it does not go to branch-4.1/branch-4.0, so the test case should be modified. ### Why are the changes needed? Fix tests. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ build/sbt "sql/testOnly *ShowCreateTableSuite" [info] Run completed in 11 seconds, 832 milliseconds. [info] Total number of tests run: 46 [info] Suites: completed 2, aborted 0 [info] Tests: succeeded 46, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 304 s (0:05:04.0), completed May 9, 2026, 5:36:26 PM ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55791 from pan3793/SPARK-56755-followup-4.0. Authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
Author
|
thanks, merged to branch-4.0 (closed via 5a785d6) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #55780 to branch-4.0
What changes were proposed in this pull request?
A follow-up of the backport (#55718) to fix the test - SPARK-55372 (4.2.0) changed the output of
SHOW CREATE TABLE ...output forSTRINGcolumns, it does not go to branch-4.1/branch-4.0, so the test case should be modified.Why are the changes needed?
Fix tests.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.