Skip to content

fix(dashboard): match auto-refresh paused-dot outline to icon color#39909

Merged
richardfogaca merged 2 commits into
apache:masterfrom
richardfogaca:fix/autorefresh-paused-dot-color
May 7, 2026
Merged

fix(dashboard): match auto-refresh paused-dot outline to icon color#39909
richardfogaca merged 2 commits into
apache:masterfrom
richardfogaca:fix/autorefresh-paused-dot-color

Conversation

@richardfogaca
Copy link
Copy Markdown
Contributor

SUMMARY

The auto-refresh status indicator's paused-state dot was using theme.colorBorder for its 1px outline, which is too dim against the surrounding container — making the dot nearly invisible. Switch the outline to theme.colorTextSecondary so it visually aligns with the adjacent play/pause icon (which already uses colorTextSecondary in the parent iconButtonStyles).

Single-line change in StatusIndicatorDot.tsx — only affects the Paused status; the other statuses (Success/Idle/Fetching/Delayed/Error) don't render a border.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: outline rendered with colorBorder — barely visible.
After: outline rendered with colorTextSecondary — matches the play icon color.

(Screenshots to be attached.)

TESTING INSTRUCTIONS

  1. Open a dashboard that has auto-refresh enabled (Edit dashboard → Properties → set a refresh interval).
  2. The status indicator next to the play/pause button should be a colored dot (green/blue/yellow/red).
  3. Click the pause button. The dot becomes a hollow circle outlined in the container background.
  4. Verify the outline color matches the play icon color (both colorTextSecondary), not the dimmer colorBorder.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
  • Introduces new feature or API
  • Removes existing feature or API

Use colorTextSecondary for the paused-state outline so it matches the
adjacent play/pause icon color, instead of the dimmer colorBorder which
made the dot hard to see against the container.
Copilot AI review requested due to automatic review settings May 6, 2026 12:12
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 6, 2026

Code Review Agent Run #e897ee

Actionable Suggestions - 0
Additional Suggestions - 1
  • superset-frontend/src/dashboard/components/AutoRefreshStatus/StatusIndicatorDot.tsx - 1
    • Theme Token Misuse · Line 144-144
      The border color uses theme.colorTextSecondary, which is semantically intended for text colors, not borders. This violates Ant Design theming best practices. Use theme.colorBorderSecondary instead for consistency with border styling across the codebase.
      Code suggestion
       @@ -143,3 +143,3 @@
      -      border: ${statusConfig.needsBorder
      -        ? `1px solid ${theme.colorTextSecondary}`
      -        : 'none'};
      +      border: ${statusConfig.needsBorder
      +        ? `1px solid ${theme.colorBorderSecondary}`
      +        : 'none'};
Review Details
  • Files reviewed - 1 · Commit Range: 46c77eb..46c77eb
    • superset-frontend/src/dashboard/components/AutoRefreshStatus/StatusIndicatorDot.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added change:frontend Requires changing the frontend dashboard Namespace | Anything related to the Dashboard labels May 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dashboard auto-refresh status indicator’s paused-state dot outline color to improve contrast and visually align it with the adjacent play/pause icon styling.

Changes:

  • Change paused-state dot outline from theme.colorBorder to theme.colorTextSecondary in StatusIndicatorDot.

@richardfogaca richardfogaca self-assigned this May 6, 2026
@richardfogaca richardfogaca added the 🎪 ⚡ showtime-trigger Trigger showtime deployment label May 6, 2026
@michaelmorera-preset
Copy link
Copy Markdown

With the fix, when the status is paused the dot becomes a hollow circle outlined in the container background.

Evidence - before and after:

Light
Screenshot 2026-05-06 at 10 54 21 PM

Dark
Screenshot 2026-05-06 at 10 49 07 PM

@richardfogaca richardfogaca added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label May 7, 2026
@richardfogaca richardfogaca requested review from EnxDev and msyavuz May 7, 2026 12:25
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels May 7, 2026
@github-actions github-actions Bot added 🎪 946cfaf 🚦 building Environment 946cfaf status: building 🎪 946cfaf 📅 2026-05-07T13-06 Environment 946cfaf created at 2026-05-07T13-06 🎪 946cfaf 🤡 richardfogaca Environment 946cfaf requested by richardfogaca 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🎪 Showtime is building environment on GHA for 946cfaf

@github-actions github-actions Bot added 🎪 946cfaf 🚦 deploying Environment 946cfaf status: deploying 🎪 946cfaf 🚦 running Environment 946cfaf status: running 🎪 🎯 946cfaf Active environment pointer - 946cfaf is receiving traffic and removed 🎪 946cfaf 🚦 building Environment 946cfaf status: building 🎪 946cfaf 🚦 deploying Environment 946cfaf status: deploying 🎪 946cfaf 🚦 running Environment 946cfaf status: running labels May 7, 2026
@github-actions github-actions Bot added 🎪 946cfaf 🌐 54.200.114.43:8080 Environment 946cfaf URL: http://54.200.114.43:8080 (click to visit) 🎪 946cfaf 🚦 running Environment 946cfaf status: running and removed 🎪 🎯 946cfaf Active environment pointer - 946cfaf is receiving traffic labels May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🎪 Showtime deployed environment on GHA for 946cfaf

Environment: http://54.200.114.43:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

@richardfogaca richardfogaca merged commit 8088c5d into apache:master May 7, 2026
68 of 70 checks passed
@richardfogaca richardfogaca deleted the fix/autorefresh-paused-dot-color branch May 7, 2026 16:07
@bito-code-review
Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend dashboard Namespace | Anything related to the Dashboard 🎪 ⚡ showtime-trigger Trigger showtime deployment size/S 🎪 ⌛ 48h Environment expires after 48 hours (default) 🎪 946cfaf 🤡 richardfogaca Environment 946cfaf requested by richardfogaca 🎪 946cfaf 🚦 running Environment 946cfaf status: running 🎪 946cfaf 🌐 54.200.114.43:8080 Environment 946cfaf URL: http://54.200.114.43:8080 (click to visit) 🎪 946cfaf 📅 2026-05-07T13-06 Environment 946cfaf created at 2026-05-07T13-06

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants