fix(dashboard): row limit warning missing for non-table charts

[msyavuz]

SUMMARY

Boolean short-circuit in SliceHeader makes countFromSecondQuery resolve to false for any non-table viz, and false != null is true, so Number(false) = 0 overrides the real rowcount fallback — every non-table chart loses the row-limit warning. Bug introduced in #37112.

-const isTableChart = formData.viz_type === 'table';
-const countFromSecondQuery =
-  isTableChart && secondQueryResponse?.data?.[0]?.rowcount;
+const isTableChart =
+  formData.viz_type === VizType.Table ||
+  formData.viz_type === VizType.TableAgGrid;
+const countFromSecondQuery = isTableChart
+  ? secondQueryResponse?.data?.[0]?.rowcount
+  : undefined;

Also widens the viz_type check to include ag-grid-table so server-paginated AG Grid charts read the rowcount sidecar query (same path the regular table uses). Same widening applied in ChartPills (explore row-count label) and Chart.tsx (CSV streaming threshold).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

TESTING INSTRUCTIONS

1. Create a bar chart with row_limit=10 against a dataset with >10 rows.
2. Add to a dashboard — warning icon should appear in the slice header.
3. Repeat with an AG Grid table with server pagination and a row limit smaller than the dataset — warning should appear.

ADDITIONAL INFORMATION

• Has associated issue: No
• Required feature flags: None
• Changes UI: Yes — restores row-limit warning icon on non-table charts
• Includes DB Migration: No
• Introduces new feature or API: No
• Removes existing feature or API: No

[bito-code-review]

Code Review Agent Run #0fb5fe

Actionable Suggestions - 0

Review Details

• Files reviewed - 4 · Commit Range: 85b9802..85b9802

  • superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
  • superset-frontend/src/dashboard/components/SliceHeader/index.tsx
  • superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx
  • superset-frontend/src/explore/components/ChartPills.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[EnxDev]

LGTM!